[CELEBORN-1760] OOM causes disk buffer unable to be released #2975
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@RexXiong @AngersZhuuuu PTAL. |
|
@leixm Can you provide some memory metrics with this PR after a worker is OOM? |
|
|
It seems that the diskBufferCount has decreased, but the total off-heap memory still cannot be released. |
|
The catch Exception here will cause fileWriter.decrementPendingWrites() to not be called, but I am not sure whether it will indirectly cause the off-heap memory to not be released. I will investigate further. |
|
The off-heap memory is not released if the disk buffer counter is decreased. This PR failed to complete its purpose. There is more to investigate to find out what happened before merging into main. |
leixm
commented
Dec 5, 2024
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java
Show resolved
Hide resolved
|
There are three problems in total
|
|
I did some tests. 2 of the nodes did not have this PR, and the memory of these two nodes could not be released. 1 node had this PR, and the memory could be released. It was obviously much lower than the previous 2 nodes. |
FMX
reviewed
Dec 6, 2024
| @@ -742,7 +742,12 @@ private[celeborn] class Worker( | |||
| synchronized { | |||
| val expiredApplicationIds = new JHashSet[String]() | |||
| expiredShuffleKeys.asScala.foreach { shuffleKey => | |||
| partitionLocationInfo.removeShuffle(shuffleKey) | |||
| partitionLocationInfo.removeShuffle(shuffleKey).foreach { loc => | |||
There was a problem hiding this comment.
StorageManager will remove expired shuffle keys which will destroy the writerd and return buffer.
|
@leixm would you mind updating the PR description to summarize the conclusion? |
RexXiong
reviewed
Dec 6, 2024
| @@ -416,7 +416,13 @@ public void write(ByteBuf data) throws IOException { | |||
| } | |||
|
|
|||
| data.retain(); | |||
| flushBuffer.addComponent(true, data); | |||
| try { | |||
| flushBuffer.addComponent(true, data); | |||
There was a problem hiding this comment.
Only the non-memory shuffle file storage type requires a call to releaseDiskBuffer?
RexXiong
approved these changes
Dec 6, 2024
Done, |
pan3793
approved these changes
Dec 6, 2024
|
ping @FMX |
RexXiong
pushed a commit
that referenced
this pull request
Dec 10, 2024
### What changes were proposed in this pull request? When OOM occurs in flushBuffer.addComponent, there are two problems. 1. decrementPendingWrites is not called, causing close PartitionDataWriter to be stuck for a period of time during commit. 2. After OOM occurs, ByteBuf is not released, causing memory leaks. ### Why are the changes needed? Fix disk buffer unable to be released ### Does this PR introduce _any_ user-facing change? Yes, it fixes a memory leak issue in some corner cases. ### How was this patch tested? I did some tests. 2 of the nodes did not have this PR, and the memory of these two nodes could not be released. 1 node had this PR, and the memory could be released. It was obviously much lower than the previous 2 nodes.  Closes #2975 from leixm/CELEBORN-1760. Authored-by: Xianming Lei <[email protected]> Signed-off-by: Shuang <[email protected]> (cherry picked from commit 372ef79) Signed-off-by: Shuang <[email protected]>
|
Thanks merge to main(v0.6.0) and branch-0.5(v0.5.3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When OOM occurs in flushBuffer.addComponent, there are two problems.
Why are the changes needed?
Fix disk buffer unable to be released
Does this PR introduce any user-facing change?
Yes, it fixes a memory leak issue in some corner cases.
How was this patch tested?
I did some tests. 2 of the nodes did not have this PR, and the memory of these two nodes could not be released. 1 node had this PR, and the memory could be released. It was obviously much lower than the previous 2 nodes.
