[feature] cherry-pick ABI Check for GitHub Actions #728
Replies: 2 comments
-
Hi, @yihong0618 Good idea, thanks.
I have to say that there is never such a formal promise from Postgres, but Postgres has been doing it very well. I have no confidence that CBDB could do more and better than Postgres for ABI, if some developers report an issue that our codes breaks their extensions which are not popular well or private ones or not formally supported by CBDB, is it a problem? For CBDB, as it's iterating fast and more codes will be open source soon. If we have to cherry-pick some bug fixes that break ABI check to a stable branch ex: 1.5.x, what shall we do ? |
Beta Was this translation helpful? Give feedback.
-
Thank you @yihong0618 and @avamingli for this thoughtful discussion about ABI compatibility checking. I agree that adopting ABI testing is valuable, but I think we need to frame it within a broader versioning and compatibility strategy. I previously proposed a PostgreSQL-style branching strategy with SemVer (#591) that could help address some of the concerns @avamingli raised:
This would give us clearer guidelines for:
The beauty of adopting SemVer is that it provides clear expectations to the community. While PostgreSQL doesn't follow SemVer, we have the opportunity to provide stronger compatibility guarantees that would benefit extension developers. Regarding the specific concerns about private/unsupported extensions - we could maintain a list of "supported extensions" that are part of our ABI testing suite. This would give us a clear scope for compatibility promises while still allowing the community to build and maintain their own extensions with clear understanding of support levels. Would it make sense to combine the ABI testing implementation with the versioning proposal? We could start with a small set of core extensions for testing and expand from there. |
Beta Was this translation helpful? Give feedback.
-
Description
Since pg17 also have an ABI issue for the latest release, I think its necessary for cloudberry too.
code in https://github.com/greenplum-db/gpdb-archive/blob/main/.github/workflows/greenplum-abi-tests.yml
its higuoxing's grate job.
and open-gpdb keep and enhance them https://github.com/open-gpdb/gpdb/tree/OPENGPDB_STABLE/.abi-check
@avamingli @edespino
Use case/motivation
No response
Related issues
No response
Are you willing to submit a PR?
Beta Was this translation helpful? Give feedback.
All reactions