Skip to content

config: fix access for config and history file #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

config: fix access for config and history file #166

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
134a5d5
config: fix access for config and history file
shwstppr Aug 4, 2025
b2929d0
fix
shwstppr Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ func saveConfig(cfg *Config) *Config {
conf.Section(defaultCoreConfig.ProfileName).ReflectFrom(&defaultProfile)
conf.SaveTo(cfg.ConfigFile)
}
makeFileUserPrivate(cfg.ConfigFile)

conf := readConfig(cfg)

Expand Down Expand Up @@ -318,6 +319,10 @@ func saveConfig(cfg *Config) *Config {
profiles = append(profiles, profile.Name())
}

if cfg.HistoryFile != "" {
makeFileUserPrivate(cfg.HistoryFile)
}

return cfg
}

Expand Down Expand Up @@ -391,6 +396,14 @@ func (c *Config) UpdateConfig(key string, value string, update bool) {
}
}

func makeFileUserPrivate(filePath string) {
if fi, err := os.Stat(filePath); err == nil && fi.Mode().IsRegular() {
if err := os.Chmod(filePath, 0600); err != nil {
fmt.Printf("Failed to set permissions on %s: %v\n", filePath, err)
}
}
}

// NewConfig creates or reload config and loads API cache
func NewConfig(configFilePath *string) *Config {
defaultConf := defaultConfig()
Expand Down