-
Notifications
You must be signed in to change notification settings - Fork 71
feature: allow file upload for getuploadparams* apis #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes apache#144 Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
|
✅ Build complete for PR #177. 🔗 Download the cmk binaries (expires on August 23, 2025) |
|
@shwstppr can we add a file= or filepath= parameter for only cmk to:
https://github.com/charmbracelet/bubbles |
Signed-off-by: Abhishek Kumar <[email protected]>
@rohityadavcloud when not in shell, should the response return any additional data or just the response of upload API? |
rohityadavcloud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test this - but really exciting feature!
|
@shwstppr , in you flick I can see you are using https. I did not get to work (yet) http works fine. Any howto for enabling https from the cli? with http: |
does |
|
@DaanHoogland my testing was with http. I think we may have to add another param to support self signed certificates |
|
finally
|
|
upload volume from local upload iso from local |
weizhouapache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
tested https upload of template, ISO and volume from local
Fixes #144
When using cmk in its shell, the following APIs will prompt for file upload,
The user can input file paths separated by a comma to allow uploading of files
cmk-upload-arg.mp4