WIP feat!: SPM support #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpogue
reviewed
Apr 27, 2024
Package.swift
Outdated
| targets: ["cordova-plugin-device"]) | ||
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/apache/cordova-ios.git", branch: "master") |
There was a problem hiding this comment.
This could potentially be an issue since we can't distribute stuff pointing to the development branch, and it's probably bad if this doesn't match the version of CordovaLib being used in the app.
I guess SwiftPM has no concept of anything like "peer dependencies"? 😕
There was a problem hiding this comment.
I've removed it since by keeping CordovaLib in the app project, having the dependency is not needed.
We will miss having plugins that are "standalone" so the source code can be built with xcodebuild without adding them to an app, but that is not possible at the moment neither, so not a big miss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a test for converting the plugin to a Swift Package Manager so apache/cordova-ios#1430 can be tested with something.
I had a local copy that didn't have the privacy manifest so I didn't add that to the Package.swift, if we go with this approach we should add it.
It removes
header-fileandsource-fileto preventcordova plugin addfrom adding those files to the cordova app since they will be added by Swift Package Manager.Using this approach plugins that want to add Swift Package Manager dependencies will have to be converted to be Swift Package Manager compatible and add dependences as they would to a regular Swift Package instead of relying in a new tag in
plugin.xmlIt's a breaking change because if converted, it will only work in the cordova-ios version that adds SPM plugins support (apache/cordova-ios#1430) since this change removes the
header-fileandsource-file.Maybe apache/cordova-ios#1430 could be tweaked to conditionally respect the
header-fileandsource-file, etc. tags and copy them only if there is noPackage.swiftin the plugin, but would require a ton more work.