Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create with plugin IDs with - generates invalid clobbers #121

Open
janpio opened this issue Apr 29, 2019 · 4 comments
Open

create with plugin IDs with - generates invalid clobbers #121

janpio opened this issue Apr 29, 2019 · 4 comments

Comments

@janpio
Copy link
Member

janpio commented Apr 29, 2019

plugman create --name cordova-plugin-math --plugin_id cordova-plugin-math --plugin_version 0.0.1

leads to

<clobbers target="cordova.plugins.cordova-plugin-math" />

which is invalid.


Fixing manually to cordova.plugins.math or similar fixes the issue.

@raphinesse
Copy link
Contributor

You gave an invalid ID. plugman should probably validate it and throw an error.

@janpio
Copy link
Member Author

janpio commented Apr 29, 2019

Why did I give an invalid ID? cordova-plugin-math is similar to cordova-plugin-device and the IDs of our other plugins.

@raphinesse
Copy link
Contributor

raphinesse commented Apr 29, 2019

You did not. Sorry, my fault. I confused it with the id in config.xml which has to be a valid identifier for all relevant platforms (i.e. a valid Java class name for Android). Those usually cannot contain -.

However, plugman actually uses the name property for the clobbers target. Which is quite funny, since that could also include spaces and whatnot.

@janpio
Copy link
Member Author

janpio commented Apr 29, 2019

ID being two different things for projects and plugins is confusing.

+1 for getting rid of create here and replacing it with a template repo and some documentation/instructions...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants