Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert BuiltInWindowFunction::CumeDist to a user defined window function #12695

Closed
Tracked by #8709
jcsherin opened this issue Oct 1, 2024 · 3 comments · Fixed by #13051
Closed
Tracked by #8709

Convert BuiltInWindowFunction::CumeDist to a user defined window function #12695

jcsherin opened this issue Oct 1, 2024 · 3 comments · Fixed by #13051
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jcsherin
Copy link
Contributor

jcsherin commented Oct 1, 2024

Is your feature request related to a problem or challenge?

Part of #8709

There is now no difference between "built in" / "prepackaged" scalar and aggregate functions in DataFusion, however there are still some "built in" window functions -- see the current source for BuiltInWindowFunction for the up to date list of what remains

The problem with having two different kinds of window functions is

  1. There are some features that may not be available to User Defined Window Functions that rely on built in
  2. Users can not easily choose which window functions to include or override the behavior if they need something different

Describe the solution you'd like

I would like to remove the "built in" version of this function and convert it to a user defined function

Describe alternatives you've considered

At a high level the process is:

  1. Add a new WindowUDFImpl in the functions-window crate
  2. Port the code from the relevant existing implementation of the the built in functions in datafusion/physical-expr/src/window
  3. Remove the BuiltInWindowFunction variant and then get everything to compile (the compiler will show you where the existing implementations are)

Additional context

Here are some good examples:

@jcsherin jcsherin added the enhancement New feature or request label Oct 1, 2024
@jcsherin jcsherin changed the title Convert BuiltInWindowFunction::CumeDist to a user defined window function Convert BuiltInWindowFunction::CumeDist to a user defined window function Oct 1, 2024
@jcsherin
Copy link
Contributor Author

jcsherin commented Oct 1, 2024

This is a good first issue.

@SteNicholas
Copy link
Member

take

@jayzhan211 jayzhan211 added the good first issue Good for newcomers label Oct 7, 2024
@jonathanc-n
Copy link
Contributor

@SteNicholas Just checking, do you have time to do this? If not, I can try to work on it or work on it with you in parallel.

Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue Oct 28, 2024
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue Oct 28, 2024
Michael-J-Ward added a commit to apache/datafusion-python that referenced this issue Nov 10, 2024
* patch datafusion deps

* migrate from deprecated RuntimeEnv::new to RuntimeEnv::try_new

Ref: apache/datafusion#12566

* remove Arc from create_udf call

Ref: apache/datafusion#12489

* doc typo

* migrage new UnnestOptions API

Ref: https://github.com/apache/datafusion/pull/12836/files

* update API for logical expr Limit

Ref: apache/datafusion#12836

* remove logical expr CrossJoin

It was removed upstream.

Ref: apache/datafusion#13076

* update PyWindowUDF

Ref: apache/datafusion#12803

* migrate window functions lead and lag to udwf

Ref: apache/datafusion#12802

* migrate window functions rank, dense_rank, and percent_rank to udwf

Ref: apache/datafusion#12648

* convert window function cume_dist to udwf

Ref: apache/datafusion#12695

* convert window function ntile to udwf

Ref: apache/datafusion#12694

* clean up functions_window invocation

* Only one column was being passed to udwf

* Update to DF 43.0.0

* Update tests to look for string_view type

* String view is now the default type for strings

* Making a variety of adjustments in wrappers and unit tests to account for the switch from string to string_view as default

* Resolve errors in doc building

---------

Co-authored-by: Tim Saucer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants