Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old static Window Functions page #13171

Closed
Tracked by #12740
alamb opened this issue Oct 29, 2024 · 3 comments · Fixed by #13395
Closed
Tracked by #12740

Remove old static Window Functions page #13171

alamb opened this issue Oct 29, 2024 · 3 comments · Fixed by #13395
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Oct 29, 2024

Part of #12740

Is your feature request related to a problem or challenge?

@Omega359 added the infrastructure to automatically create documentation from code in #12668

After #13161 Window Functions still have two pages

  1. A "static" one: https://datafusion.apache.org/user-guide/sql/window_functions.html
  2. A "auto generated" one https://datafusion.apache.org/user-guide/sql/window_functions_new.html

Describe the solution you'd like

Once all the window functions have all been migrated

We should remove the static window functions page (in favor of the auto generated one). We can follow the model of #13161

Describe alternatives you've considered

Basically this means for the scalar, window and aggregate functions:

  1. Delete the static file docs/source/user-guide/sql/window_functions.md
  2. Rename the _new files like docs/source/user-guide/sql/window_functions_new.md to docs/source/user-guide/sql/window_functions.md
  3. Update the index page docs/source/user-guide/sql/index.rst to remove the _new entries
  4. Update the script dev/update_function_docs.sh so it writes to the scalar_functions.md file

Additional context

@jonathanc-n
Copy link
Contributor

This is just waiting on #12649

@buraksenn
Copy link
Contributor

It seems assignee removed their assignment from that issue. Let me implement that and remove old static windows then

@alamb
Copy link
Contributor Author

alamb commented Nov 13, 2024

@jonathanc-n notes that now we have merged the following PR this is unblocked 🐱 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants