Skip to content

FixedSizeBinary support in min/max accumulators #16513

Open
@alexwilcoxson-rel

Description

@alexwilcoxson-rel

Is your feature request related to a problem or challenge?

In our system we have certain FixedSizeBinary columns that are now starting to get used in joins. Therefore we are hitting the min/max accumulator paths where FixedSizeBinary is not supported

DataType::Binary => {
typed_min_max_batch_binary!(&values, BinaryArray, Binary, min_binary)
}
DataType::LargeBinary => {
typed_min_max_batch_binary!(
&values,
LargeBinaryArray,
LargeBinary,
min_binary
)
}
DataType::BinaryView => {
typed_min_max_batch_binary!(
&values,
BinaryViewArray,
BinaryView,
min_binary_view
)
}

Describe the solution you'd like

In arrow 55.2 release, the min/max functions for FixedSizeBinary will be available apache/arrow-rs#7674

Use these in the above referenced code

Describe alternatives you've considered

As a workaround we leverage schema adapter to use Binary. This workaround is relatively straightforward in concept. In our code base it is a little more complicated due to other reasons.

This would allow out of the box datafusion to just work with these column types.

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions