-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Open
Labels
api changeChanges the API exposed to users of the crateChanges the API exposed to users of the cratedatafusionChanges in the datafusion crateChanges in the datafusion crateenhancementNew feature or requestNew feature or requestperformanceMake DataFusion fasterMake DataFusion faster
Description
Is your feature request related to a problem or challenge?
Currently the CountAccumulator
implementation requires values: &[ArrayRef]
to be passed.
In order to eliminate scanning a (first) column, we need to be able to accept a RecordBatch
or num_rows
instead of values: &[ArrayRef]
.
Describe the solution you'd like
Rather than changing every method to accept a RecordBatch
(and needing to update the code), I propose adding two new methods:
update_record_batch(&mut self, recordbatch: &RecordBatch)
retract_record_batch(&mut self, recordbatch: &RecordBatch)
The default implementation of the methods can use update_batch
and update_record_batch
(i.e. assume having at least one column).
In the aggregation code, we call update_record_batch
/retract_record_batch
instead.
Describe alternatives you've considered
No response
Additional context
No response
alamb2010YOUY01
Metadata
Metadata
Assignees
Labels
api changeChanges the API exposed to users of the crateChanges the API exposed to users of the cratedatafusionChanges in the datafusion crateChanges in the datafusion crateenhancementNew feature or requestNew feature or requestperformanceMake DataFusion fasterMake DataFusion faster