-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format plan with line number. #9443
Comments
I think adding a line number to the front of each line is a easier way. |
Adding a line number seems like a reasonable thing to try to me. The reason we had |
Maybe we can mark it as a |
Good idea @my-vegetable-has-exploded -- I hav done so. Thank you |
Hi, i would love to take this issue as a starting point |
I think it maybe helpful to take a breif look |
hi @alamb could you help me give one more review to this PR? |
Thanks again for #10019 @duongcongtoai -- great stuff. 🚀 |
Is your feature request related to a problem or challenge?
When I try to complete #8416 , I found it hard to review changes in plan in tpch sqllogictests.
I think the main reason is that CoalesceBatchesExec and RepartitionExec::RoundRobinBatch would make git diff aligns the result in unexcepted position.
Takes q11.slt.part as example, it aligns CoalesceBatchesExec and RepartitionExec::RoundRobinBatch but ignore the
--
changes.If we remove CoalesceBatchesExec and RepartitionExec::RoundRobinBatch, it works well to find the
--
changes.Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: