chore: enforce clippy lint needless_pass_by_value to physical-expr-common #18556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corasaurus-hex
approved these changes
Nov 8, 2025
Contributor
corasaurus-hex
left a comment
corasaurus-hex
left a comment
There was a problem hiding this comment.
seems straight-forward, especially since there seem to be no required changes due to it
Contributor
|
Thanks you! I'm going to go ahead and merge this since it's a straightforward change to enforce an automated rule that we already agreed to roll out (tracked in #18503). |
adriangb
approved these changes
Nov 9, 2025
foskey51
deleted the
datafusion-physical-expr-common/enforce-clippy-needless-pass-by-value
branch
codetyri0n
pushed a commit
to codetyri0n/datafusion
that referenced
this pull request
Nov 11, 2025
…mmon (apache#18556) ## Which issue does this PR close? - Closes apache#18543 ## What changes are included in this PR? enforce clippy lint `needless_pass_by_value` to `datafusion-physical-expr-common` ## Are these changes tested? yes ## Are there any user-facing changes? no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
clippy::needless_pass_by_valuetodatafusion-physical-expr-common#18543What changes are included in this PR?
enforce clippy lint
needless_pass_by_valuetodatafusion-physical-expr-commonAre these changes tested?
yes
Are there any user-facing changes?
no