Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement](good-first-issue) Support some date functions #44932

Open
2 of 3 tasks
zclllyybb opened this issue Dec 3, 2024 · 8 comments
Open
2 of 3 tasks

[Enhancement](good-first-issue) Support some date functions #44932

zclllyybb opened this issue Dec 3, 2024 · 8 comments
Assignees

Comments

@zclllyybb
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Description

We need to implement function NEXT_DAY and PREVIOUS_DAY, for the next day/previous day of input argument(which accept datev2 or datetimev2 type)
and for LAST_DAY we support the second argument(optinal, if not provided, act like got month so that the old behaviours won't be change) to get the last day of current week/month/day/quarter... and so on

Solution

To support a function, we need:

function implementation and registration in BE
function signature and visitor for nereids planner in FE
the constant fold implementation in FE, behave just same with it in BE, like functions/executable/NumericArithmetic.java in https://github.com/apache/doris/pull/40744/files
another function docs pr in https://github.com/apache/doris-website
you can reference pr like https://github.com/apache/doris/pull/33005/files

and ATTN! we must have enough testcases, like what https://github.com/apache/doris/pull/40462/files did.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@cat-with-cat
Copy link
Contributor

I want to try it, please assign it to me.

@cutiepie-10
Copy link

cutiepie-10 commented Dec 6, 2024

May I help in this issue @cat-with-cat ?
I am new and want to contribute something on this issue

@HashHaran
Copy link

Hey @cat-with-cat @zclllyybb @zhangstar333, I am interested to contribute to doris. I will start by learning more about the project and the code base. Meanwhile, @cat-with-cat if you can update on whether you have started working on the issue here. I could get started working on the issue.

@zclllyybb
Copy link
Contributor Author

hi @cutiepie-10 and @HashHaran . As I know @cat-with-cat is working on this issue. I released a new one here. If you interested in it, feel free to pick it.

@riya9142
Copy link

hey @cat-with-cat and @zclllyybb , in case you need any help please let me know . I am eager to contribute to this issue.

@zclllyybb
Copy link
Contributor Author

hey @cat-with-cat and @zclllyybb , in case you need any help please let me know . I am eager to contribute to this issue.

hey @cat-with-cat could you share your advance and planning here?

@cat-with-cat
Copy link
Contributor

hey @cat-with-cat and @zclllyybb , in case you need any help please let me know . I am eager to contribute to this issue.

hey @riya9142 and @zclllyybb , I have completed the coding of the logic and am now conducting tests. Thanks

@zclllyybb
Copy link
Contributor Author

hey @cat-with-cat and @zclllyybb , in case you need any help please let me know . I am eager to contribute to this issue.

hey @riya9142 and @zclllyybb , I have completed the coding of the logic and am now conducting tests. Thanks

great. so @riya9142 if you are interested in contributing in Doris, maybe you can look https://github.com/orgs/apache/projects/424? It's a great project which has many subtasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants