Skip to content

branch-4.0: [Bug](Jni)should delete local ref after convert to global ref #57513 #57598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

branch-4.0: [Bug](Jni)should delete local ref after convert to global ref #57513 #57598

merged 1 commit into from
Nov 4, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 31, 2025

Cherry-picked from #57513

@github-actions github-actions bot requested a review from yiguolei as a code owner October 31, 2025 18:05
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 31, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 31, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 31, 2025

run buildall

1 similar comment
@zhangstar333
Copy link
Contributor

zhangstar333 commented Nov 3, 2025

run buildall

@zhangstar333
[Bug](Jni)should delete local ref after convert to global ref (#57513)
7fde40b 
hashmap_local_object is NewObject as local ref, and it's convert to global ref to as return value, so should call delete local ref to avoid JVM can't GC.
@zhangstar333 zhangstar333 force-pushed the auto-pick-57513-branch-4.0 branch from 98ef6a3 to 7fde40b Compare November 4, 2025 02:09
@zhangstar333
Copy link
Contributor

zhangstar333 commented Nov 4, 2025

run buildall

@yiguolei yiguolei merged commit eb4a8f6 into branch-4.0 Nov 4, 2025
24 of 29 checks passed
@github-actions github-actions bot deleted the auto-pick-57513-branch-4.0 branch November 4, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen @zhangstar333 @yiguolei @dataroaring