Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Monitoring indicators support otel format indicator export #13902

Open
3 of 4 tasks
songxiaosheng opened this issue Mar 11, 2024 · 5 comments
Open
3 of 4 tasks
Assignees
Labels
component/sdk Related with apache/dubbo help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance

Comments

@songxiaosheng
Copy link
Member

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component

Java SDK (apache/dubbo)

Descriptions

Currently, dubbo indicators support the use of micromter, but do not support the export of otel format. They need to be compatible with the otel format exporter.

Related issues

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@songxiaosheng songxiaosheng added type/need-triage Need maintainers to triage component/need-triage Need maintainers to triage labels Mar 11, 2024
@songxiaosheng songxiaosheng changed the title [Feature] Monitoring indicators support otel format indicator export [Task] Monitoring indicators support otel format indicator export Mar 11, 2024
@AlbumenJ AlbumenJ added help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance component/sdk Related with apache/dubbo and removed type/need-triage Need maintainers to triage component/need-triage Need maintainers to triage labels Mar 12, 2024
@ShenFeng312
Copy link
Contributor

may be we can use export adapter like spring-boot

@glmapper
Copy link

I would like to take over this task, please assign it to me. @songxiaosheng

@glmapper
Copy link

glmapper commented Apr 2, 2024

I finished the initial coding and testing, here are my design ideas and some sample data, I hope to submit it to the community and then discuss it together!

  1. add new module dubbo-metrics/dubbo-metrics-otlp,the primary purpose is to introduce a dependency
<dependency>
    <groupId>io.micrometer</groupId>
    <artifactId>micrometer-registry-otlp</artifactId>
  </dependency>
  1. Same as the default and prometheus, provide OtlpMetricsReporter and OtlpMetricsReporterFactory to support otlp protocol format data.
  2. there are no other changes, if you want use otlp, pls config dubbo.metrics.protocol=otlp to appoint you protocol type

consumer site promethues protocol data:

metrics-prometheus.json

consumer site otlp protocol data:
metrics-otlp.json

@songxiaosheng
Copy link
Member Author

Okay, you can submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/sdk Related with apache/dubbo help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance
Projects
Status: Todo
Development

No branches or pull requests

4 participants