[#5966] improvment(authorization): Add path based securable object and user group mapping interface #5967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunliu
reviewed
Dec 25, 2024
Comment on lines
32
to
58
| public enum Type implements AuthorizationMetadataObject.Type { | ||
| /** A path is mapped the path of storages like HDFS, S3 etc. */ | ||
| FILESET(MetadataObject.Type.FILESET), | ||
| TABLE(MetadataObject.Type.TABLE), | ||
| SCHEMA(MetadataObject.Type.SCHEMA), | ||
| CATALOG(MetadataObject.Type.CATALOG); | ||
|
|
||
| private final MetadataObject.Type metadataType; | ||
|
|
||
| Type(MetadataObject.Type type) { | ||
| this.metadataType = type; | ||
| } | ||
|
|
||
| public MetadataObject.Type metadataObjectType() { | ||
| return metadataType; | ||
| } | ||
|
|
||
| public static PathBasedMetadataObject.Type fromMetadataType(MetadataObject.Type metadataType) { | ||
| for (PathBasedMetadataObject.Type type : PathBasedMetadataObject.Type.values()) { | ||
| if (type.metadataObjectType() == metadataType) { | ||
| return type; | ||
| } | ||
| } | ||
| throw new IllegalArgumentException( | ||
| "No matching RangerMetadataObject.Type for " + metadataType); | ||
| } | ||
| } |
There was a problem hiding this comment.
We only define one PathBased metadata object type PATH
public enum Type implements AuthorizationMetadataObject.Type {
/** A path is mapped the path of storages like HDFS, S3 etc. */
PATH(MetadataObject.Type.FILESET, MetadataObject.Type.TABLE, MetadataObject.Type.SCHEMA, MetadataObject.Type. CATALOG);
private final Set<MetadataObject.Type> validTypes;
Type(MetadataObject.Type... types) {
this.validTypes = EnumSet.copyOf(Arrays.asList(types));
}
public boolean isValidType(MetadataObject.Type type) {
return validTypes.contains(type);
}
}
yuqi1129
commented
Dec 25, 2024
| PATH(MetadataObject.Type.FILESET); | ||
| FILESET_PATH(MetadataObject.Type.FILESET), | ||
| TABLE_PATH(MetadataObject.Type.TABLE), | ||
| SCHEMA_PATH(MetadataObject.Type.SCHEMA), |
There was a problem hiding this comment.
@xunliu Please take a look and let me know if this is acceptable to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the following things:
Why are the changes needed?
It's a need for path-based authorization
Fix: #5966
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
Existing tests.