Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsInstanceEnabled should consider both HELIX_ENABLED and InstanceOperation #2975

Open
xyuanlu opened this issue Dec 2, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@xyuanlu
Copy link
Contributor

xyuanlu commented Dec 2, 2024

Describe the bug

When HELIX_ENABLED is true, but InstanceOperation is DISABLED, IsInstanceEnabled returns false. Where it should return true

To Reproduce

This is constantly reproduceble

Expected behavior

Helix deprecated the HELIX_ENABLED and added a new InstanceOperation field.
If an instance is disabled using InstanceOperation but enabled using setting HELIX_ENABLED to true (by helix lib with old version), IsInstanceEnabled will return false.
When HELIX_ENABLED is true, but InstanceOperation is DISABLED, IsInstanceEnabled returns false. Where it should return true.

Additional context

Add any other context about the problem here.

@xyuanlu xyuanlu added the bug Something isn't working label Dec 2, 2024
@xyuanlu xyuanlu mentioned this issue Dec 2, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant