[issue-2998] remove invalid check in isValidLabelValue (#3015)

Co-authored-by: aias00 <[email protected]>
apache · Jan 24, 2025 · 2f3abfb · 2f3abfb
1 parent 95739d9
commit 2f3abfb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/...n/java/org/apache/hertzbeat/collector/collect/http/promethus/exporter/ExporterParser.java b/...n/java/org/apache/hertzbeat/collector/collect/http/promethus/exporter/ExporterParser.java
@@ -17,7 +17,6 @@
 
 package org.apache.hertzbeat.collector.collect.http.promethus.exporter;
 
-import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
@@ -419,7 +418,7 @@ private boolean isValidLabelNameContinuation(char c) {
      * @return true/false
      */
     private boolean isValidLabelValue(String s) {
-        return s != null && s.equals(new String(s.getBytes(StandardCharsets.UTF_8)));
+        return s != null;
     }
 
     private boolean isSum(String s) {

diff --git a/...ic/src/main/java/org/apache/hertzbeat/collector/collect/prometheus/parser/TextParser.java b/...ic/src/main/java/org/apache/hertzbeat/collector/collect/prometheus/parser/TextParser.java
@@ -17,7 +17,6 @@
 
 package org.apache.hertzbeat.collector.collect.prometheus.parser;
 
-import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.LinkedList;
 import java.util.List;
@@ -300,6 +299,6 @@ private static boolean isValidLabelNameContinuation(char c) {
      * @return true/false
      */
     private static boolean isValidLabelValue(String s) {
-        return s != null && s.equals(new String(s.getBytes(StandardCharsets.UTF_8)));
+        return s != null;
     }
 }