Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[collector]feature:Add monitoring metrics for consumer groups in Kafka client #2887

Merged
merged 11 commits into from
Dec 20, 2024

Conversation

doveLin0818
Copy link
Contributor

@doveLin0818 doveLin0818 commented Dec 19, 2024

Issue:#2885

What's changed?

1.The Kafka client monitoring metrics have been extended with a consumer information module, including consumer group ID, number of consumer group members, topics subscribed by the consumer group, partition offset, and lag offset metrics and each metric has been tested.

2.The ambiguity in the Chinese description of the partition count field in the topic_offset module has been fixed.

3.The hertzbeat community documentation has also been updated accordingly.

The example diagram is shown below:
image

Checklist

  • [✅] I have read the Contributing Guide
  • [✅] I have written the necessary doc or comment.
  • [] I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

…a client

[home]doc:For the Kafka client documentation, add information about consumer metrics and address the ambiguity in the Chinese description regarding partition count changes.
[manager]doc:For the Kafka client monitoring template, add consumer group metrics and address the ambiguity in the Chinese description regarding partition count changes.
@github-actions github-actions bot added the doc Improvements or additions to documentation label Dec 19, 2024
@tomsun28 tomsun28 added the good first pull request Good for newcomers label Dec 19, 2024
@tomsun28 tomsun28 added this to the 1.7.0 milestone Dec 19, 2024
doveLin0818 and others added 5 commits December 19, 2024 22:59
…a client

[home]doc:For the Kafka client documentation, add information about consumer metrics and address the ambiguity in the Chinese description regarding partition count changes.
[manager]doc:For the Kafka client monitoring template, add consumer group metrics and address the ambiguity in the Chinese description regarding partition count changes.
Copy link
Member

@zhangshenghang zhangshenghang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

thanks @doveLin0818 , It is recommended to change Offset of Each Partition to [0,10,2] for easier understanding

@doveLin0818
Copy link
Contributor Author

doveLin0818 commented Dec 20, 2024

图像

#2887 @zhangshenghang "Hello, yeah,This way is easier to understand. I have now modified the format as shown in the image below."
image

Copy link
Member

@zhangshenghang zhangshenghang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomsun28 tomsun28 merged commit 6aff6ed into apache:master Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation good first pull request Good for newcomers
Projects
Development

Successfully merging this pull request may close these issues.

4 participants