New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR UPDATE] always specify the char encoding in getBytes #3011

Merged

tomsun28 merged 2 commits into apache:master from pjfanning:utf8

Jan 23, 2025

Contributor

pjfanning commented Jan 22, 2025

if you don't specify the char encoding, then it is up to the JVM config on the machine
this means different users can see different results

pjfanning and others added 2 commits

January 22, 2025 22:00


          always specify the char encoding in getBytes

c836b0f


          Merge branch 'master' into utf8

35c901e

tomsun28 added the improve label

tomsun28 approved these changes

View reviewed changes

Contributor

tomsun28 left a comment

LGTM 👍

tomsun28 merged commit 6509b8b into apache:master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels