Skip to content

Commit 4a5b5e6

Browse files
authored
HIVE-29245: Normalize Java license headers, part 1 - illegal Javadoc (#6125)
* Add RegexpHeader * Don't run RAT for checkstyle * HIVE-29245: Normalize Java license headers, part 1 - illegal Javadoc * Fix checkstyle.xml * Revert avro-generated files * Raise the severity of RegexpHeader
1 parent 52b6fc3 commit 4a5b5e6

File tree

89 files changed

+217
-167
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

89 files changed

+217
-167
lines changed

checkstyle/asf.header.incremental

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
^\/\*$
2+
^( \*| \* +.*)$
3+
^ \*\/$

checkstyle/checkstyle.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,13 @@
6464
<module name="Header">
6565
<property name="headerFile" value="${config_loc}/asf.header"/>
6666
</module>
67+
<!-- HIVE-29245: An incremental process to normalize headers. We will finally remove the following one -->
68+
<module name="RegexpHeader">
69+
<property name="severity" value="error"/>
70+
<property name="headerFile" value="${config_loc}/asf.header.incremental"/>
71+
<property name="fileExtensions" value="java"/>
72+
<property name="multiLines" value="2"/>
73+
</module>
6774

6875
<!-- Maximum file line length -->
6976
<module name="FileLength">

checkstyle/suppressions.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,10 @@
2525
<suppress checks=".*" files="gen\-java"/>
2626
<!-- Ignore JDBM code -->
2727
<suppress checks=".*" files="ql\/util\/jdbm"/>
28+
<!-- Copies of an external libraries -->
29+
<suppress checks="RegexpHeader" files="serde\/src\/java\/org\/apache\/hadoop\/hive\/serde2\/lazy\/fast\/StringToDouble\.java"/>
30+
<suppress checks="RegexpHeader" files="llap-server\/src\/java\/org\/apache\/hadoop\/hive\/llap\/daemon\/impl\/PriorityBlockingDeque\.java"/>
31+
<!-- Generated by Avro -->
32+
<suppress checks="RegexpHeader" files="hbase-handler\/src\/test\/org\/apache\/hadoop\/hive\/hbase\/avro\/.*\.java"/>
33+
<suppress checks="RegexpHeader" files="kafka-handler\/src\/test\/gen\/org\/apache\/hadoop\/hive\/kafka\/SimpleRecord\.java"/>
2834
</suppressions>

common/src/java/org/apache/hadoop/hive/common/GcTimeMonitor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/**
1+
/*
22
* Licensed to the Apache Software Foundation (ASF) under one
33
* or more contributor license agreements. See the NOTICE file
44
* distributed with this work for additional information

common/src/java/org/apache/hadoop/hive/common/type/Date.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/**
1+
/*
22
* Licensed to the Apache Software Foundation (ASF) under one
33
* or more contributor license agreements. See the NOTICE file
44
* distributed with this work for additional information

common/src/java/org/apache/hadoop/hive/common/type/Timestamp.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/**
1+
/*
22
* Licensed to the Apache Software Foundation (ASF) under one
33
* or more contributor license agreements. See the NOTICE file
44
* distributed with this work for additional information

common/src/java/org/apache/hive/common/util/CleanerUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/**
1+
/*
22
* Licensed to the Apache Software Foundation (ASF) under one
33
* or more contributor license agreements. See the NOTICE file
44
* distributed with this work for additional information

itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/BlackholeOperator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/**
1+
/*
22
* Licensed under the Apache License, Version 2.0 (the "License");
33
* you may not use this file except in compliance with the License.
44
* You may obtain a copy of the License at

itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/operators/AbstractOperatorBench.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/**
1+
/*
22
* Licensed to the Apache Software Foundation (ASF) under one
33
* or more contributor license agreements. See the NOTICE file
44
* distributed with this work for additional information

itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/operators/VectorGroupByOperatorBench.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/**
1+
/*
22
* Licensed to the Apache Software Foundation (ASF) under one
33
* or more contributor license agreements. See the NOTICE file
44
* distributed with this work for additional information

0 commit comments

Comments
 (0)