From c156448d7d740a4f12295a48eff0058c71071aab Mon Sep 17 00:00:00 2001
From: Dmitry Kryukov <dk2k@ya.ru>
Date: Wed, 2 Apr 2025 22:56:10 +0300
Subject: [PATCH] HIVE-28876 Strings should be compared with equals(), not with
 ==

---
 .../hadoop/hive/ql/ddl/table/constraint/ConstraintsUtils.java | 2 +-
 .../ql/exec/repl/bootstrap/load/table/LoadPartitions.java     | 3 ++-
 .../org/apache/hadoop/hive/ql/exec/repl/util/ReplUtils.java   | 4 ++--
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/constraint/ConstraintsUtils.java b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/constraint/ConstraintsUtils.java
index ad1515d4f9e9..6008be4874d9 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/constraint/ConstraintsUtils.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/constraint/ConstraintsUtils.java
@@ -457,7 +457,7 @@ public static void validateCheckConstraint(List<FieldSchema> columns, List<SQLCh
           throw new SemanticException(
               ErrorMsg.INVALID_CSTR_SYNTAX.getMsg("Invalid type for CHECK constraint: ") + cc.getCheck_expression());
         }
-        if (checkExpr.getTypeInfo().getTypeName() != serdeConstants.BOOLEAN_TYPE_NAME) {
+        if (!serdeConstants.BOOLEAN_TYPE_NAME.equals(checkExpr.getTypeInfo().getTypeName())) {
           throw new SemanticException(
               ErrorMsg.INVALID_CSTR_SYNTAX.getMsg("Only boolean type is supported for CHECK constraint: ") +
               cc.getCheck_expression() + ". Found: " + checkExpr.getTypeInfo().getTypeName());
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java b/ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java
index c3760aaeb976..018c0c5ca8c1 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java
@@ -64,6 +64,7 @@
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 
 import static org.apache.hadoop.hive.conf.HiveConf.ConfVars.REPL_DUMP_METADATA_ONLY;
 import static org.apache.hadoop.hive.conf.HiveConf.ConfVars.REPL_DUMP_SKIP_IMMUTABLE_DATA_COPY;
@@ -307,7 +308,7 @@ private boolean addTasksForPartition(Table table, AlterTableAddPartitionDesc add
         + partSpecToString(partSpec.getPartSpec()) + " with source location: "
         + partSpec.getLocation());
       if (!lastProcessedStageFound && lastPartSpec != null &&
-        lastPartSpec.getLocation() != partSpec.getLocation()) {
+              !Objects.equals(lastPartSpec.getLocation(), partSpec.getLocation())) {
         //Don't process copy task if already processed as part of previous run
         continue;
       }
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/ReplUtils.java b/ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/ReplUtils.java
index 2c42c9b6156f..861c802427dd 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/ReplUtils.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/ReplUtils.java
@@ -361,8 +361,8 @@ public static boolean isCreateOperation(DDLOperation<?> ddlOperation) {
   }
 
   private static String getMetricStageName(String stageName, ReplicationMetricCollector metricCollector) {
-    if( stageName == "REPL_DUMP" || stageName == "REPL_LOAD" || stageName == "ATLAS_DUMP" || stageName == "ATLAS_LOAD"
-            || stageName == "RANGER_DUMP" || stageName == "RANGER_LOAD" || stageName == "RANGER_DENY"){
+    if( "REPL_DUMP".equals(stageName) || "REPL_LOAD".equals(stageName) || "ATLAS_DUMP".equals(stageName) || "ATLAS_LOAD".equals(stageName)
+            || "RANGER_DUMP".equals(stageName) || "RANGER_LOAD".equals(stageName) || "RANGER_DENY".equals(stageName)){
       return stageName;
     }
     if(isDumpMetricCollector(metricCollector)){