Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Support Time64Type[ns] #1169

Open
kevinjqliu opened this issue Sep 12, 2024 · 5 comments
Open

[feature request] Support Time64Type[ns] #1169

kevinjqliu opened this issue Sep 12, 2024 · 5 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@kevinjqliu
Copy link
Contributor

Feature Request / Improvement

Currently Time64Type[ns] (Time64Type with nanosecond precision) is not supported. Only Time64Type[ms] (Time64Type with microsecond precision) is supported.

elif isinstance(primitive, pa.Time64Type) and primitive.unit == "us":
return TimeType()

Also add the ability to downcast, similar to the pa.types.is_timestamp(primitive): branch.

Interestingly Time64Type[ns] is False when evaluating pa.types.is_timestamp(primitive).

@kevinjqliu kevinjqliu added the good first issue Good for newcomers label Sep 12, 2024
@zaryab-ali
Copy link

@kevinjqliu if the issue is still available can you assign it to me please

@kevinjqliu
Copy link
Contributor Author

kevinjqliu commented Sep 19, 2024

@zaryab-ali assigned to you

@zaryab-ali
Copy link

@kevinjqliu can you please review my PR and let me know if i made a mistake (please check with extra caution as it is my first contribution to any open source project)

@JE-Chen JE-Chen mentioned this issue Sep 25, 2024
@zaryab-ali
Copy link

zaryab-ali commented Oct 1, 2024

@kevinjqliu did someone else solve the issue while it was still assigned to me??? or is this still open??? because i just made the changes and added the test case

@kevinjqliu
Copy link
Contributor Author

@zaryab-ali Hey, sorry about the confusion. I did not see that 2 PRs were opened for the same issue. I just assumed it was from the same person.
The issue is still open, #1188, #1206, and #1215 are all trying to address it. Since it's already assigned to you, I'll take a look at #1215.

Hey @JE-Chen, since this issue is already assigned to @zaryab-ali, would you mind collaborating with him on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants