-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] Support Time64Type[ns] #1169
Comments
@kevinjqliu if the issue is still available can you assign it to me please |
@zaryab-ali assigned to you |
@kevinjqliu can you please review my PR and let me know if i made a mistake (please check with extra caution as it is my first contribution to any open source project) |
@kevinjqliu did someone else solve the issue while it was still assigned to me??? or is this still open??? because i just made the changes and added the test case |
@zaryab-ali Hey, sorry about the confusion. I did not see that 2 PRs were opened for the same issue. I just assumed it was from the same person. Hey @JE-Chen, since this issue is already assigned to @zaryab-ali, would you mind collaborating with him on it? |
Feature Request / Improvement
Currently
Time64Type[ns]
(Time64Type
with nanosecond precision) is not supported. OnlyTime64Type[ms]
(Time64Type
with microsecond precision) is supported.iceberg-python/pyiceberg/io/pyarrow.py
Lines 1071 to 1072 in d8d509f
Also add the ability to downcast, similar to the
pa.types.is_timestamp(primitive):
branch.Interestingly
Time64Type[ns]
isFalse
when evaluatingpa.types.is_timestamp(primitive)
.The text was updated successfully, but these errors were encountered: