test: add unit tests for register table

Signed-off-by: Alan Tang <[email protected]>

Author: Standing-Man

crates/catalog/sql/src/catalog.rs

@@ -216,11 +216,6 @@ impl SqlCatalog {
             }
         }
     }
-
-    /// Get the catalogs `FileIO`
-    pub fn file_io(&self) -> FileIO {
-        self.fileio.clone()
-    }
 }
 
 #[async_trait]
@@ -773,11 +768,11 @@ impl Catalog for SqlCatalog {
         table_ident: &TableIdent,
         metadata_location: String,
     ) -> Result<Table> {
-        if !self.table_exists(table_ident).await? {
-            return no_such_table_err(table_ident);
+        if self.table_exists(table_ident).await? {
+            return table_already_exists_err(table_ident);
         }
 
-        let metadata = TableMetadata::read_from(&self.fileio, metadata_location.clone()).await?;
+        let metadata = TableMetadata::read_from(&self.fileio, &metadata_location).await?;
 
         let namespace = table_ident.namespace();
         let tbl_name = table_ident.name().to_string();
@@ -792,7 +787,7 @@ impl Catalog for SqlCatalog {
             .identifier(table_ident.clone())
             .metadata_location(metadata_location)
             .metadata(metadata)
-            .file_io(self.file_io())
+            .file_io(self.fileio.clone())
             .build()?)
     }
 
@@ -1930,4 +1925,58 @@ mod tests {
             "Unexpected => No such table: TableIdent { namespace: NamespaceIdent([\"a\"]), name: \"tbl1\" }"
         );
     }
+
+    #[tokio::test]
+    async fn test_register_table_throws_error_if_table_with_same_name_already_exists() {
+        let warehouse_loc = temp_path();
+        let catalog = new_sql_catalog(warehouse_loc.clone()).await;
+        let namespace_ident = NamespaceIdent::new("a".into());
+        create_namespace(&catalog, &namespace_ident).await;
+        let table_name = "tbl1";
+        let table_ident = TableIdent::new(namespace_ident.clone(), table_name.into());
+        create_table(&catalog, &table_ident).await;
+
+        assert_eq!(
+            catalog
+                .register_table(&table_ident, warehouse_loc)
+                .await
+                .unwrap_err()
+                .to_string(),
+            format!("Unexpected => Table {:?} already exists.", &table_ident)
+        );
+    }
+
+    #[tokio::test]
+    async fn test_register_table() {
+        let warehouse_loc = temp_path();
+        let catalog = new_sql_catalog(warehouse_loc.clone()).await;
+        let namespace_ident = NamespaceIdent::new("a".into());
+        create_namespace(&catalog, &namespace_ident).await;
+
+        let table_name = "abc";
+        let location = warehouse_loc.clone();
+        let table_creation = TableCreation::builder()
+            .name(table_name.into())
+            .location(location.clone())
+            .schema(simple_table_schema())
+            .build();
+
+        let table_ident = TableIdent::new(namespace_ident.clone(), table_name.into());
+        let expected_table = catalog
+            .create_table(&namespace_ident, table_creation)
+            .await
+            .unwrap();
+
+        assert_table_eq(&expected_table, &table_ident, &simple_table_schema());
+
+        let _ = catalog.drop_table(&table_ident).await;
+
+        let table = catalog
+            .register_table(&table_ident, location.clone())
+            .await
+            .unwrap();
+
+        assert_eq!(table.identifier(), expected_table.identifier());
+        assert_eq!(table.metadata_location(), Some(location.as_str()));
+    }
 }