-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issues of iceberg rust v0.4.0 Release #739
Comments
I believe we need something like https://github.com/apache/opendal/blob/main/scripts/release.py to help generate ASF source tarballs for core and python binding. |
@c-thiel Hi Christian, thanks for flagging the issue! I've been tracking the discussion, and it looks like we are getting closer to a consensus on how we'd like to resolve the issue. I will ensure the resolution gets taken into account within this release. |
It's better to include #665 in. I'm working on this now. |
Hi @c-thiel, are you working on this now? I hope we can start the release process next week before Christmas; otherwise, we might have to see the new release until next year. |
@Xuanwo |
Thank you for working on the issue @c-thiel and keeping this thread updated! |
Also update on #706 : I've investigated it and it looks like a non-issue. I'm waiting on the issue reporters to respond before closing it out |
It looks like two issues have been resolved, and #771 is very close to being merged. We'll get started with the release shortly! 🚀
Hi @Xuanwo - I started taking a look into this, and it looks like the existing release.sh script would already create a tarball including all the source code for the core rust crates, as well as those of the python bindings. The opendal reference implementation creates different tarballs for each binding and integrations separately, all including the the source code of the rust core crates as well. Since we have decided to have a single coupled release schedule for the rust core crates as well as the associated bindings, I'm wondering if it would just make sense to keep the source codes in the same tarball to simplify the process. We could also increment the version of pyiceberg_core library to 0.4.0 if that would make more sense for the tightly coupled release schedule. I looked up the ASF release policy, and I couldn't find any recommendations on how we should organize the source code for sub-distributions. I do see guidelines for how the source code needs to be uploaded and signed, and that the name of the packages will need to be prefixed by I'm curious to hear your thoughts on this suggestion @Xuanwo @Fokko and @liurenjie1024 do you think uploading the source package as a single artifact would make sense in our case? |
I've cleaned up the milestone, and I think we're good to go 🚀 @sungwy Since we release everything simultaneously, I would highly recommend putting everything in a single tarbal to keep things simple. |
Hi, @sungwy, I prefer to split them into different tarballs since they have different versions. However, I don't have a strong opinion on this. I believe it would be great to release them first and then refine the process in the next release. |
Should we cut a branch for 0.4.0-rc1? |
Should we merge #795 before release? |
Hi, I personally believe #795 is not a blocker. Let's proceed with the release and avoid adding more PRs unless we have truly critical issues to address. What do you think? cc @ZENOTME Sorry if I put too much burden here, but I really want to finalize a release before 2025 arrives. As I mentioned in previous comments, this week is the only one before Christmas when we can make it happen. |
Both look good to me. According to #795 (comment), this reorder will not happen if we use in avro format. In this release version, we don't expose the interface to let the user get the serializable representation, so I think this issue will not affect the user in this version.🤔 |
Thank you for your understanding. Let's continue addressing this issue without delaying the 0.4.0 release. |
Sounds good folks. I'll get started with the release. Based on the discussion above, I think we are good to start the release, with the new Python binding included in the same source package. Could someone help review this PR so we can get the versions synced to 0.4.0? #808 |
Merged. Let's move! |
Let's get this party started~! 🎈 Here's the PR to remove deprecated functions, and bump the version of iceberg-rust for review: #809 |
Yes, I'm on it 🖖 |
This issue is used to track tasks of the iceberg rust 0.4.0 release.
Tasks
Blockers
PartialEq
forStruct
#706UnboundPartitionSpec
instead? #694The remaining issues listed under 0.4.0 Milestone do not seem like blockers, and could be tracked in the next release.
Build Release
GitHub Side
ASF Side
Voting
Official Release
For details of each step, please refer to: https://rust.iceberg.apache.org/release
The text was updated successfully, but these errors were encountered: