Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading use of LoadTableResponse in RESTTableOperations.commit() #11767

Open
1 of 3 tasks
creechy opened this issue Dec 12, 2024 · 0 comments
Open
1 of 3 tasks

Misleading use of LoadTableResponse in RESTTableOperations.commit() #11767

creechy opened this issue Dec 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@creechy
Copy link

creechy commented Dec 12, 2024

Apache Iceberg version

None

Query engine

None

Please describe the bug 🐞

This is a little nit-picky, but the Iceberg REST spec defines the response of the UpdateTable (commit) operation to be CommitTableResponse

$ref: '#/components/responses/CommitTableResponse'

But the code implementing UpdateTable (commit) uses LoadTableResponse to hold the results of the operation.

LoadTableReponse appears to be a superset of CommitTableResponse, and the subsequent code that uses the response only uses fields in the latter, but it is a little misleading for the casual reader who may expect all the data from LoadTableResponse to be available.

Willingness to contribute

  • I can contribute a fix for this bug independently
  • I would be willing to contribute a fix for this bug with guidance from the Iceberg community
  • I cannot contribute a fix for this bug at this time
@creechy creechy added the bug Something isn't working label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant