Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong name for parquet page row count min and max stats #11770

Open
1 of 3 tasks
namrathamyske opened this issue Dec 12, 2024 · 1 comment
Open
1 of 3 tasks

Wrong name for parquet page row count min and max stats #11770

namrathamyske opened this issue Dec 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@namrathamyske
Copy link
Contributor

Apache Iceberg version

1.7.1 (latest release)

Query engine

None

Please describe the bug 🐞

In TableProperties, the properties PARQUET_ROW_GROUP_CHECK_MAX_RECORD_COUNT (write.parquet.row-group-check-max-record-count) and PARQUET_ROW_GROUP_CHECK_MIN_RECORD_COUNT (write.parquet.row-group-check-min-record-count) are actually passed to Parquet as withMaxRowCountForPageSizeCheck and withMinRowCountForPageSizeCheck, respectively. It would be more accurate to rename them as PARQUET_PAGE_SIZE_CHECK_MAX_RECORD_COUNT (write.parquet.page-size-check-max-record-count) and PARQUET_PAGE_SIZE_CHECK_MIN_RECORD_COUNT (write.parquet.page-size-check-min-record-count).

Willingness to contribute

  • I can contribute a fix for this bug independently
  • I would be willing to contribute a fix for this bug with guidance from the Iceberg community
  • I cannot contribute a fix for this bug at this time
@namrathamyske namrathamyske added the bug Something isn't working label Dec 12, 2024
@namrathamyske
Copy link
Contributor Author

cc: @stevenzwu @rdblue @nastra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant