Skip to content

Commit 2de1a07

Browse files
committed
Remove the import/no-internal-modules lint rule
With Node.js adopting a standard for packages to declare their exports, this rule may not be useful anymore. It should be legal to import any valid export from a package. An open [issue] on eslint-plugin-import tracks this ecosystem feature and when that resolves there may be a better rule to enable. [issue]: import-js/eslint-plugin-import#1868
1 parent f50583b commit 2de1a07

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

.eslintrc.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
* under the License.
1919
*/
2020

21-
const path = require('path');
2221
const babel = require('@babel/core');
2322

2423
// Use the root babel.config.js for module resolution.
@@ -44,7 +43,6 @@ module.exports = {
4443
'import/newline-after-import': 'error',
4544
'import/no-absolute-path': 'error',
4645
'import/no-default-export': 'error',
47-
'import/no-internal-modules': 'error',
4846
'import/order': [
4947
'error',
5048
{
@@ -141,12 +139,6 @@ module.exports = {
141139
assert: true,
142140
},
143141
rules: {
144-
'import/no-internal-modules': [
145-
'error',
146-
{
147-
allow: [path.resolve(__dirname, './packages/*/src/**')],
148-
},
149-
],
150142
'import/no-relative-parent-imports': 'off',
151143
},
152144
},

0 commit comments

Comments
 (0)