From e2ef3ce468c7e4cee4a7da93b462f20555af5922 Mon Sep 17 00:00:00 2001 From: Bertil Chapuis Date: Tue, 5 Nov 2024 21:20:15 +0100 Subject: [PATCH] Fix issues detected by sonar --- .../main/java/org/apache/baremaps/geocoder/DataRowMapper.java | 1 + .../org/apache/baremaps/geoparquet/GeoParquetGroupFactory.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/baremaps-core/src/main/java/org/apache/baremaps/geocoder/DataRowMapper.java b/baremaps-core/src/main/java/org/apache/baremaps/geocoder/DataRowMapper.java index 7414dfd8e..c0cf39404 100644 --- a/baremaps-core/src/main/java/org/apache/baremaps/geocoder/DataRowMapper.java +++ b/baremaps-core/src/main/java/org/apache/baremaps/geocoder/DataRowMapper.java @@ -55,6 +55,7 @@ public Document apply(DataRow dataRow) { return doc; } + @SuppressWarnings("squid:S6541") private void applyValue(DataColumn column, Document doc, Object value) { String columnName = column.name(); DataColumn.Type type = column.type(); diff --git a/baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetGroupFactory.java b/baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetGroupFactory.java index 97cdb3570..29d254d14 100644 --- a/baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetGroupFactory.java +++ b/baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetGroupFactory.java @@ -90,7 +90,7 @@ else if (!field.isPrimitive()) { geoParquetSchema); } - // TODO: Handle logical types + // Handle logical types else if (field.getLogicalTypeAnnotation() != null && field.getLogicalTypeAnnotation().equals(LogicalTypeAnnotation.stringType())) { return new StringField(field.getName(), cardinality);