Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add How to connect mysql server which requires SSL #648

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

abeizn
Copy link
Contributor

@abeizn abeizn commented Sep 26, 2023

Summary

docs: add How to connect mysql server which requires SSL

Does this close any open issues?

Related to apache/incubator-devlake#5659

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, can you link the Implementation PR in the description as well?

```
2. Verify the SSL certificate: you can add &ca-cert=/path/to/your/ca-certificate.crt to DB_URL variable, for example:
```
DB_URL=mysql://merico:[email protected]:3306/lake?charset=utf8mb4&parseTime=True&ca-cert=/path/to/your/DigiCertGlobalRootCA.crt.pem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tls=custom should be added to the query string according to the implementation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and, we should stress that this is NOT supported in python plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should stress that this is NOT supported in python plugin.
I think no need to explain here, tls=custom is replaced in our code. Users only need to add&ca-cert=/path/to/your/ca-certificate.crt in the db url and it will be OK.

@abeizn
Copy link
Contributor Author

abeizn commented Sep 26, 2023

repo link: apache/incubator-devlake#5659

@klesh klesh merged commit 3f46411 into apache:main Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants