Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-2492][CH] fix posexplode cannot handle null value as argument #3106

Merged
merged 7 commits into from
Sep 12, 2023

Conversation

taiyang-li
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #2492)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions
Copy link

#2492

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994 liuneng1994 merged commit 3db45b7 into apache:main Sep 12, 2023
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3106_time.csv log/native_master_09_11_2023_c93fea040_time.csv difference percentage
q1 44.61 44.05 -0.564 98.74%
q2 24.71 24.42 -0.294 98.81%
q3 38.33 37.16 -1.162 96.97%
q4 41.04 41.39 0.345 100.84%
q5 69.44 69.52 0.081 100.12%
q6 6.63 6.57 -0.055 99.17%
q7 86.73 83.17 -3.565 95.89%
q8 80.92 80.30 -0.616 99.24%
q9 115.69 117.13 1.438 101.24%
q10 47.47 47.78 0.311 100.66%
q11 19.52 21.01 1.494 107.65%
q12 24.77 26.08 1.311 105.29%
q13 49.74 50.52 0.772 101.55%
q14 17.76 13.64 -4.120 76.80%
q15 33.28 29.03 -4.249 87.23%
q16 15.72 16.10 0.381 102.42%
q17 119.40 119.95 0.552 100.46%
q18 162.40 162.64 0.243 100.15%
q19 12.37 12.83 0.459 103.71%
q20 29.83 29.04 -0.794 97.34%
q21 240.67 236.97 -3.700 98.46%
q22 15.69 15.62 -0.063 99.60%
total 1296.72 1284.93 -11.794 99.09%

@yangzhg
Copy link
Member

yangzhg commented Dec 18, 2023

map_from_arrays_unaligned is not exist in velox ?

@taiyang-li
Copy link
Contributor Author

taiyang-li commented Dec 18, 2023

map_from_arrays_unaligned is not exist in velox ?

yes, it's a special internal function created to fix #2492. Velox doesn't need to care about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] posexplode cannot handle null value as argument
6 participants