Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vectorgraphics2d from xchart #4083

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

weiting-chen
Copy link
Contributor

What changes were proposed in this pull request?

Remove vectorgraphcis2d dependency from xchart since GPL license issue

How was this patch tested?

Tested in my local server, but need to test pass in Github Action

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

@weiting-chen
Copy link
Contributor Author

This library "vectorgraphics2d" has used GPL license only and no other option can be used, so I remove it to avoid any concern from Apache's license check.

@zhouyuan zhouyuan changed the title [DNM]remove vectorgraphics2d from xchart Remove vectorgraphics2d from xchart Dec 18, 2023
@zhouyuan zhouyuan merged commit 9f6af14 into apache:main Dec 19, 2023
18 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4083_time.csv log/native_master_12_18_2023_ecf765da9_time.csv difference percentage
q1 32.90 33.40 0.506 101.54%
q2 26.66 24.92 -1.740 93.47%
q3 37.95 39.07 1.119 102.95%
q4 39.62 39.68 0.055 100.14%
q5 73.66 72.52 -1.142 98.45%
q6 7.11 7.08 -0.034 99.53%
q7 85.75 85.20 -0.550 99.36%
q8 86.70 87.23 0.527 100.61%
q9 123.17 127.21 4.044 103.28%
q10 46.68 45.48 -1.207 97.41%
q11 20.43 19.88 -0.546 97.33%
q12 26.82 25.92 -0.901 96.64%
q13 45.93 46.99 1.064 102.32%
q14 17.06 15.90 -1.158 93.21%
q15 27.48 30.75 3.273 111.91%
q16 15.40 15.88 0.482 103.13%
q17 102.07 103.20 1.127 101.10%
q18 151.99 151.92 -0.076 99.95%
q19 12.92 12.96 0.044 100.34%
q20 27.55 28.35 0.796 102.89%
q21 226.38 229.29 2.918 101.29%
q22 13.84 13.82 -0.027 99.81%
total 1248.08 1256.65 8.575 100.69%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants