From d0c049a396c622115cca004836f4829f7cb80440 Mon Sep 17 00:00:00 2001 From: yan ma Date: Wed, 20 Mar 2024 16:03:41 +0800 Subject: [PATCH 1/2] update clang-format version to v4.11.0 for Velox backend --- .github/workflows/code_style.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/code_style.yml b/.github/workflows/code_style.yml index e932790755e6..f1c9c2548324 100644 --- a/.github/workflows/code_style.yml +++ b/.github/workflows/code_style.yml @@ -36,9 +36,9 @@ jobs: steps: - uses: actions/checkout@v4 - name: Run clang-format style check for C/C++ programs. - uses: jidicula/clang-format-action@v3.5.1 + uses: jidicula/clang-format-action@v4.11.0 with: - clang-format-version: '12' + clang-format-version: '15' check-path: ${{ matrix.path['check'] }} fallback-style: 'Google' # optional From e1d752a8aef52b78540c8aecf0f6c5b97f7588f3 Mon Sep 17 00:00:00 2001 From: yan ma Date: Wed, 20 Mar 2024 16:18:53 +0800 Subject: [PATCH 2/2] fix format check failures --- cpp/velox/substrait/SubstraitToVeloxExpr.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cpp/velox/substrait/SubstraitToVeloxExpr.cc b/cpp/velox/substrait/SubstraitToVeloxExpr.cc index fd68be16e2bc..f795f9c9ebd5 100644 --- a/cpp/velox/substrait/SubstraitToVeloxExpr.cc +++ b/cpp/velox/substrait/SubstraitToVeloxExpr.cc @@ -420,7 +420,8 @@ VectorPtr SubstraitVeloxExprConverter::literalsToVector( case ::substrait::Expression_Literal::LiteralTypeCase::kNull: { auto veloxType = SubstraitParser::parseType(childLiteral.null()); auto kind = veloxType->kind(); - return VELOX_DYNAMIC_SCALAR_TYPE_DISPATCH_ALL(constructFlatVector, kind, elementAtFunc, childSize, veloxType, pool_); + return VELOX_DYNAMIC_SCALAR_TYPE_DISPATCH_ALL( + constructFlatVector, kind, elementAtFunc, childSize, veloxType, pool_); } case ::substrait::Expression_Literal::LiteralTypeCase::kIntervalDayToSecond: return constructFlatVector(elementAtFunc, childSize, INTERVAL_DAY_TIME(), pool_);