Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: New DRL Parser : Test failure : Unknown language level #5681

Closed
tkobayas opened this issue Feb 9, 2024 · 2 comments
Closed

Experiment: New DRL Parser : Test failure : Unknown language level #5681

tkobayas opened this issue Feb 9, 2024 · 2 comments
Assignees

Comments

@tkobayas
Copy link
Contributor

tkobayas commented Feb 9, 2024

Parent issue: #5678

For example, KnowledgeBuilderTest.testWarnOnFunctionReplacementand some other tests fail with

java.lang.RuntimeException: Unknown language level
	at org.drools.drl.parser.DRLFactory.getDRLParser(DRLFactory.java:109)
	at org.drools.drl.parser.DRLFactory.buildParser(DRLFactory.java:71)
	at org.drools.drl.parser.DrlParser.parse(DrlParser.java:87)
	at org.drools.drl.parser.DrlParser.parse(DrlParser.java:93)
	at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.addPackageFromDrl(KnowledgeBuilderImpl.java:314)
	at org.drools.compiler.builder.impl.KnowledgeBuilderImpl.addPackageFromDrl(KnowledgeBuilderImpl.java:300)

It means DrlParser and DRLFactory require more (hopefully clean) integration with the new parser.

@tkobayas
Copy link
Contributor Author

tkobayas commented Feb 14, 2024

I'm working in a way that removing DRL10 and introduce a system property drools.drl.antlr4.parser.enabled.

Kind of overlapping #5681

@tkobayas
Copy link
Contributor Author

Fixed by #5693

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🎯 Done in 🦉 KIE Podling Board Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant