Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new-parser] review drlExpression and drlPrimary in DRLParser.g4 #5807

Open
tkobayas opened this issue Mar 27, 2024 · 2 comments
Open

[new-parser] review drlExpression and drlPrimary in DRLParser.g4 #5807

tkobayas opened this issue Mar 27, 2024 · 2 comments
Assignees
@tkobayas

Comments

@tkobayas
Copy link
Contributor

tkobayas commented Mar 27, 2024 •
edited
Loading

Parent issue

Issue

#5806 (comment)

drlExpression and drlPrimary in DRLParser.g4 are extended rules from JavaParser.g4.

However, constraint related rules should respect DRL6Expressions.g4 so that we can avoid a situation like "This is possible with DRL6Expressions, but not possible with DRLParser". It would also be a good way to find additional unit tests.
@tkobayas tkobayas self-assigned this Mar 27, 2024
@tkobayas tkobayas mentioned this issue Mar 27, 2024
Merged
@tkobayas
Copy link
Contributor Author

tkobayas commented May 1, 2024

We have imported DRL6Expressions.g4. This issue could be used to review and clean up unnecessary rules in DRLParser.g4.

@tkobayas
Copy link
Contributor Author

Not high priority

@tkobayas tkobayas mentioned this issue Jun 11, 2024
Closed
@tkobayas tkobayas mentioned this issue Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkobayas tkobayas

Labels
None yet
Projects
🦉 KIE Podling Board
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tkobayas