You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So while the problem occurs during parsing (mismatched input), parsers report different exception types with slightly different messages. This should be unified.
Tests
DRL6Expressions has error reporting test coverage in org.drools.drl.parser.antlr4.DRLExprParserTest#testMismatchedInput and other test methods.
DRLParser should receive equal test coverage.
The text was updated successfully, but these errors were encountered:
DRL6Expressions
is a bit ahead ofDRLParser
so I take that as a benchmark.Impl
The code that registers error listeners is very different for both parsers. It could be unified and reused.
API
Contents of
parser.getErrors()
should be unified.DRL6Expressions
DRLParser
So while the problem occurs during parsing (mismatched input), parsers report different exception types with slightly different messages. This should be unified.
Tests
DRL6Expressions
has error reporting test coverage inorg.drools.drl.parser.antlr4.DRLExprParserTest#testMismatchedInput
and other test methods.DRLParser
should receive equal test coverage.The text was updated successfully, but these errors were encountered: