From 925ad9898ed939d0baf319981a6d401b1408eacc Mon Sep 17 00:00:00 2001 From: Rashmesh Radhakrishnan Date: Thu, 18 Jul 2024 13:15:24 -0700 Subject: [PATCH] Enhanced testSalienceIntegerAndLoadOrder for better memory management and type safety --- .../ExecutionFlowControlTest.java | 27 ++++++++++++------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/ExecutionFlowControlTest.java b/drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/ExecutionFlowControlTest.java index ebbd2d9f352..8c0b40dcb94 100644 --- a/drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/ExecutionFlowControlTest.java +++ b/drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/ExecutionFlowControlTest.java @@ -71,19 +71,26 @@ public static Collection getParameters() { @Test(timeout = 10000) public void testSalienceIntegerAndLoadOrder() throws Exception { KieBase kbase = KieBaseUtil.getKieBaseFromClasspathResources(this.getClass(), kieBaseTestConfiguration, "test_salienceIntegerRule.drl"); - KieSession ksession = kbase.newKieSession(); - final List list = new ArrayList(); - ksession.setGlobal( "list", list ); + KieSession ksession = null; + try { + ksession = kbase.newKieSession(); + final List list = new ArrayList<>(); + ksession.setGlobal("list", list); - final PersonInterface person = new Person( "Edson", "cheese" ); - ksession.insert( person ); + final PersonInterface person = new Person("Edson", "cheese"); + ksession.insert(person); - ksession.fireAllRules(); + ksession.fireAllRules(); - assertThat(list.size()).as("Three rules should have been fired").isEqualTo(3); - assertThat(list.get(0)).as("Rule 4 should have been fired first").isEqualTo("Rule 4"); - assertThat(list.get(1)).as("Rule 2 should have been fired second").isEqualTo("Rule 2"); - assertThat(list.get(2)).as("Rule 3 should have been fired third").isEqualTo("Rule 3"); + assertThat(list.size()).as("Three rules should have been fired").isEqualTo(3); + assertThat(list.get(0)).as("Rule 4 should have been fired first").isEqualTo("Rule 4"); + assertThat(list.get(1)).as("Rule 2 should have been fired second").isEqualTo("Rule 2"); + assertThat(list.get(2)).as("Rule 3 should have been fired third").isEqualTo("Rule 3"); + } finally { + if (ksession != null) { + ksession.dispose(); + } + } } @Test