Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt kogito-runtimes/springboot integration tests to avoid usage of extensions flag for kogito-maven-plugin #1462

Closed
gitgabrio opened this issue Sep 3, 2024 · 0 comments · Fixed by apache/incubator-kie-kogito-runtimes#3656

Comments

@gitgabrio
Copy link

gitgabrio commented Sep 3, 2024

Currently, kogito-.maven-plugin requires usage of extensions flag (see here but this prevent its usage inside modules on the same repository.
Refactor the springboot/integration test poms to "recreate" the required lifecicle of kogito-maven-plugin, without the usage of the extensions flag.
This is a temporary workaround, to be removed after #1460 have been implemented

E.g.

<plugin>
        <artifactId>maven-compiler-plugin</artifactId>
        <version>${version.compiler.plugin}</version>
        <configuration>
          <release>${maven.compiler.release}</release>
        </configuration>
        <executions>
          <execution>
            <id>pre-kogito-compile</id>
            <phase>generate-sources</phase>
            <goals>
               <goal>compile</goal>
            </goals>
          </execution>
        </executions>
      </plugin>
      <plugin>
          <groupId>org.kie.kogito</groupId>
          <artifactId>kogito-maven-plugin</artifactId>
          <version>${project.version}</version>
          <executions>
            <execution>
              <id>kogito-generate-resources</id>
              <phase>generate-sources</phase>
              <goals>
                 <goal>generateModel</goal>
              </goals>
            </execution>
            <execution>
              <id>kogito-process-classes</id>
              <phase>process-classes</phase>
              <goals>
                 <goal>process-model-classes</goal>
              </goals>
            </execution>
          </executions>
      </plugin>
      <plugin>
          <artifactId>maven-compiler-plugin</artifactId>
          <version>${version.compiler.plugin}</version>
          <configuration>
            <release>${maven.compiler.release}</release>
          </configuration>
      </plugin>

This is the lifecicle to recreate

maven-compiler-plugin         | compile                | default-compile               | compile              
kogito-maven-plugin           | compile                | default-generateModel         | generateModel        
maven-compiler-plugin         | compile                | default-compile-1             | compile              
kogito-maven-plugin           | process-classes        | default-process-model-classes | process-model-classes

@elguardian @baldimir @fjtirado

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎯 Done
1 participant