Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Generate form code for human interactions" command in the BPMN VS Code extension #1498

Closed
ljmotta opened this issue Sep 26, 2024 · 7 comments · Fixed by apache/incubator-kie-tools#2660
Assignees
Labels
area:bpmn Related to BPMN area:tools Issues affecting Apache KIE tooling projects

Comments

@ljmotta
Copy link

ljmotta commented Sep 26, 2024

Add the form generation command to the BPMN VS Code extension using the "jbpm-form-generator" package introduced in #1493. The command should be named "Generate form code for human interactions". It will use the compiled JSON Schemas to generate the form code into the "src/resources/forms" folder.

The command should be interactive, giving the user the option to generate a Patternfly or Bootstrap code. Also, it should give the option to select which human interactions are desired.

@ljmotta ljmotta added the area:bpmn Related to BPMN label Sep 26, 2024
@ljmotta ljmotta self-assigned this Sep 26, 2024
@ljmotta ljmotta added the area:tools Issues affecting Apache KIE tooling projects label Sep 26, 2024
@jomarko
Copy link

jomarko commented Sep 27, 2024

@ljmotta hi, thank you, I would like to ask about the command name:

  • will it be somehow clear it is a command that belongs to KIE VSCode extension? I mean some prefix maybe? 'KIE: ....' ?
  • is there a reason the command name dos not contain keywords like 'jbpm', 'bpmn', 'workflow', is that because it may be used for generating forms of 'anything'

I do not have a strong opinion about the points I bring. I am probably fine if we do not change the name. However, sharing the fact, that me, I would try to search in list of VSCode commands by keywords mention in first or second point.

@ljmotta
Copy link
Author

ljmotta commented Sep 27, 2024

@jomarko I understand what you mean. I was relying on a prefix to give the context of the command, as you're right, the form code generation is exclusively for workflow projects. I just checked, and all our KIE VS Code extensions doesn't use a prefix, which is a common approach across other community extensions (e.g. Prettier, Go, TypeScript, ESLint, etc...). For this case, I'll add the prefix to the BPMN VS Code using its extension name (KIE BPMN Editor), and we should create a separated issue to tackle this on other extensions.

Now, with the prefix in place, the current command name would be: KIE BPMN Editor: Generate form code for human interactions, and I guess you're right too to include de jbpm as we need to use the compiled JSON Schemas. Maybe KIE BPMN Editor: Generate form code for human interactions from jBPM project. WDYT?

@jomarko
Copy link

jomarko commented Oct 1, 2024

@ljmotta thank you, the last proposal KIE BPMN Editor: Generate form code for human interactions from jBPM project sounds to me quite long. I mean, would it fit the menu [1]? However, I am not an expert in other extension commands, maybe it is totally common to use also long command name. I like the proposal to contain a lot of information, what the command actually does and if it fits the menu [1], then I am fine with it.

For example, Devbox: Generate a Dockerfile from devbox.json is 46 characters long while KIE BPMN Editor: Generate form code for human interactions from jBPM project is 76 characters long.

[1]
image

@jaimeizuz
Copy link

Hi @ljmotta

Sorry if this is not the best place to expose this. I was wondering if the scope of this issue might reach DMN too in some way.

I've seen many DMN developers using VS Code, most of them not very skilled from a technical point of view (poor knowledge on Java, Maven, OpenAPI...) and there's something they've been missing: user-friendly forms to test both DMN models and individual decision nodes.

Do you think that this initiative could also be applied to DMN?

Best regards,

Jaime

@ljmotta
Copy link
Author

ljmotta commented Oct 11, 2024

@jomarko The extension name is Apache KIE™ BPMN Editor. The command with the extension name as prefix was trimmed down as we can see in the image below:

image

Shortening it to BPMN Editor fits well:

image

As Apache KIE™ BPMN Editor can be too long for a command prefix, I think it's harmless to left as BPMN Editor.

@ljmotta
Copy link
Author

ljmotta commented Oct 11, 2024

@jaimeizuz Hi! Sorry for the late response.

Could you please create a separate issue for DMN? We would need to make this feature from scratch. The BPMN form code generation already existed as a CLI tool which is being moved to the BPMN VS Code extension.

@jomarko
Copy link

jomarko commented Oct 14, 2024

@ljmotta thank you for the screenshot, I agree with your shortening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:bpmn Related to BPMN area:tools Issues affecting Apache KIE tooling projects
Projects
None yet
3 participants