Adjust forms-generation-tool to properly release the cli for Linux, macOS and Windows

[porcelli]

No description provided.

[tiagobento]

Releasing on NPM with a bin entry should be enough for people to be able to use it... All agree?

[porcelli]

for now, it's ok!

[jomarko]

@tiagobento @porcelli would you mind to add more detailed description, what are acceptance criteria. i see you discussed in comments, but still not sure . Is there any existing librabry on npm repository that can be like example of demanded result?

[ljmotta]

@jomarko The build-env is an example of package that has a bin entry on its package.json. With the bin entry it'll be possible to directly use it in the CLI after the package is installed. Now, to use without node it would require to release the binaries, and for that we need to add steps in our CI as we have for the extended-services and kn-plugin-workflow packages.

[yesamer]

@porcelli @tiagobento We completed all the tasks related to form-generation-tool, should we start to work on this ticket too?
//cc @pefernan

[porcelli]

+1 from me

[jomarko]

Hello team, I just wonder what are the 'acceptance criteria' here.

• what should be the cli command name? should it be form-generation-tool? or should the name somehow reflect apache, or kie ?
• am I correct user will be intended to firstly execute npm install -g @kie-tools/form-generation-tool to make this new cli command available on his/her machine?

I was able to prepare a packages/form-generation-tool/src/cli/cli.js file:

#! /usr/bin/env node
/* License omitted */
require("../../dist/index");

then I prepared update in packages/form-generation-tool/package.json:

  "bin": {
    "form-generation-tool": "./src/cli/cli.js"
  },

and was able to execute it as npm run form-generation-tool from the packages/form-generation-tool folder

However I somehow feel, this is not enough verification before some npm publish is done.

Could somebody help me with better understanding acceptance criteria? How to be sure prepared changes are expected?

[yesamer]

• what should be the cli command name? should it be form-generation-tool? or should the name somehow reflect apache, or kie ?

+1 using form-generation-tool as command name

• am I correct user will be intended to firstly execute npm install -g @kie-tools/form-generation-tool to make this new cli command available on his/her machine?

I guess this is inevitable, I mean, the user needs to install the library before using that. I don't see alternatives.

@pefernan @tiagobento can you please share your thoughts too?

[jomarko]

@yesamer thank you for your input. I prepared a PR when I follow this naming - form-generation-tool.

Anyone, please feel free to have a look on the PR

[pefernan]

Sorry for being late here,

• what should be the cli command name? should it be form-generation-tool? or should the name somehow reflect apache, or kie ?

+1 to keep the form-generation-tool name

• am I correct user will be intended to firstly execute npm install -g @kie-tools/form-generation-tool to make this new cli command available on his/her machine?

+1 too

[jomarko]

FYI, this feature is cancelled with #1493