EPIC - Upgrade PatternFly from v4 to v5 on kie-tools

[tiagobento]

PatternFly's migration guide: https://www.patternfly.org/get-started/upgrade/#patternfly-5

Issues in this epic:

• Patternfly v5 upgrade analysis incubator-kie-tools#2642
• [SonataFlow] Upgrade Patternfly to v5 incubator-kie-tools#2641
• Write a dependency upgrade guide incubator-kie-tools#2677

---

Related:

• [uniforms-patternfly] Upgrade @patternfly to v5.0.0 incubator-kie-tools#1877
• KOGITO-9712: Use Patternfly V5 in Dashbuilder incubator-kie-tools#1921

[yesamer]

uniforms-patternfly module has been updated by @lordrip here https://github.com/KaotoIO/kaoto-next/tree/main/packages/uniforms-patternfly
Thank you, Ricardo!

[lordrip]

@yesamer, I moved the library to a standalone repository https://github.com/KaotoIO/uniforms-patternfly. The idea is to have independent versioning after each merge to the main branch and also make it easier to bring the library back kie-tools when makes sense.

[jomarko]

Hello @lordrip @yesamer @tiagobento , should we do the same for kogito-apps react codebase?

[lordrip]

Hi @jomarko, what do you mean by the same?

[jomarko]

@lordrip upgrade patternfly dependencies from 4.x to 5.x for kogito-apps

[tiagobento]

For anyone interested on the comments above, everything related to React has been moved from kogito-apps to kie-tools.

[fantonangeli]

@tiagobento I generated the full list of components to updated on kie-tools. I used the command:
pnpm -rc exec "[ -d 'src' ] && npx @patternfly/pf-codemods@latest ./src || exit 0" >pf-codemods-v5.logs

Here is the list of files
Here is the full logs

[tiagobento]

@fantonangeli Nice. I guess that's gonna be the way to achieve this... Trying some things to find out what's the best strategy to tackle it. I guess it's fine to upgrade in parts.. we just need to know what packages will be done on each part

[fantonangeli]

@tiagobento I think we can create a new patternfly-v5-upgrade branch, configuring syncpack to allow Patternfly v4 and v5 together.
Then we upgrade packages by packages or block of packages, depending on how many files needs to be updated.
Then open the final PR to main branch.
WDYT?

[lordrip]

Hi @tiagobento @fantonangeli, I think you are aware, but just in case, this is the fork of uniforms-patternfly that we did for Kaoto 👉 https://github.com/KaotoIO/uniforms-patternfly using patternfly v5.

The reason why I mention it is because maybe it could simplify the update process a bit because perhaps you could migrate one application at a time (I don't know if this is something that you're after), despite the application using uniforms, otherwise I guess you would need to upgrade uniforms first. 🤔

[fantonangeli]

Thank you @lordrip for your very nice work.
I think we can use your uniforms-patternfly to update @kie-tools/uniforms-patternfly

[jomarko]

Hi everyone, I would like to understand better the approach we are going to proceed. To me, it sounds we discuss currently these options:

• upgrade patternfly from v4 to v5 in small steps directly in kie-tools packages, what may bring a problem of parallel usage of different versions?
• replace kie-tools/uniforms-patternfly with KaotoIO/uniforms-patternfly, I am not sure if this is somehow conforming to kie-tools strategy, I mean there is effort to have kie-tools as one mono repo

thank you for any comment, I am always happy when similar upgrades are achieved

[fantonangeli]

Hi @jomarko ,

• upgrade patternfly from v4 to v5 in small steps directly in kie-tools packages, what may bring a problem of parallel usage of different versions?
  We are still defining the groups of packages, possibly isolated, to update, limiting the impact to other groups and how to proceed.

• replace kie-tools/uniforms-patternfly with KaotoIO/uniforms-patternfly, I am not sure if this is somehow conforming to kie-tools strategy, I mean there is effort to have kie-tools as one mono repo
  I was referring to import their code to kie-tools/packages/uniform-patternfly If it's an "ok way to proceed". Of course we will set again the folders following the kie-tools style.