Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holistic review of non-quarkus setup chapter #588

Open
domhanak opened this issue Mar 18, 2024 · 3 comments · Fixed by #648
Open

Holistic review of non-quarkus setup chapter #588

domhanak opened this issue Mar 18, 2024 · 3 comments · Fixed by #648
Assignees

Comments

@domhanak
Copy link
Contributor

Goal
Holistic review of non-quarkus setup guides

@LuboTerifaj
Copy link
Contributor

I found several issues. I provided some fixes in #648 . The one improvement that should be addressed later I reported here:

@LuboTerifaj LuboTerifaj moved this from ⏳ In Progress to 🧐 In Review in 🦉 KIE Podling Board Jun 11, 2024
@github-project-automation github-project-automation bot moved this from 🧐 In Review to 🎯 Done in 🦉 KIE Podling Board Jun 14, 2024
@domhanak
Copy link
Contributor Author

Reopening this issue as some of these part were not reviewed with latest main state and only with 0.32.0 release.
See comment

@domhanak domhanak reopened this Jun 18, 2024
@domhanak domhanak assigned domhanak and unassigned LuboTerifaj Jun 18, 2024
@LuboTerifaj
Copy link
Contributor

There is nothing more to review in the chapter at current stage.

The only part affected for the next release in setup guides chapter is kn workflow plugin. However, the documentation is not prepared yet and it is tracked by #661.

In #584 epic, there is no any specific version or branch mentioned. Since the main is not stable and it is evolving, we cannot review the "temporary" state, but we should rather focus on stable releases. The feature/changes may not be complete yet during the documentation review and the reviewing of such changes may not make sense.

I would suggest to review necessary changes under a different issue. If you think it's appropriate to track it here, feel free to keep it open. However, from my pov, it's not ideal to reopen issues like this one since we could do that over and over again as there will be coming new features and bug fixes.

I understand the documentation processes for SonataFlow project may not perfect at the moment and we do not use versioning in github issues as we used in jira, so there is certainly space for improvement in this area.

I also understand your good intention, so do it as it suits you best.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎯 Done
Development

Successfully merging a pull request may close this issue.

2 participants