From b6ef994a70d81ca182dcf29caf581f8cffa0bd31 Mon Sep 17 00:00:00 2001 From: rhkp Date: Tue, 13 Aug 2024 12:05:15 -0400 Subject: [PATCH] Address review comments - add GH action for unit tests --- .github/workflows/db-migrator-tests.yml | 55 +++++++++++++++++++ images/tools/sonataflow-db-migrator/pom.xml | 6 +- .../postgresql/migrator/DBMigratorTest.java | 4 -- .../migrator/MigrationServiceTest.java | 4 -- 4 files changed, 58 insertions(+), 11 deletions(-) create mode 100644 .github/workflows/db-migrator-tests.yml diff --git a/.github/workflows/db-migrator-tests.yml b/.github/workflows/db-migrator-tests.yml new file mode 100644 index 000000000..a60b3c44f --- /dev/null +++ b/.github/workflows/db-migrator-tests.yml @@ -0,0 +1,55 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: Sonataflow DB Migrator Unit Tests + +on: + pull_request: + types: [opened, reopened, edited, synchronize] + branches: + - main + paths: + - 'images/tools/sonataflow-db-migrator/**' + - '!images/tools/sonataflow-db-migrator/README.md' + - '.github/workflows/db-migrator-tests.yml' + +jobs: + unit-tests: + strategy: + matrix: + OS: [ubuntu-latest] + JAVA_VERSION: [17] + MAVEN_VERSION: [3.9.8] + timeout-minutes: 10 + name: Unit Tests + runs-on: ${{ matrix.OS }} + steps: + - name: Java and Maven Setup + uses: apache/incubator-kie-kogito-pipelines/.ci/actions/maven@main + with: + java-version: ${{ matrix.JAVA_VERSION }} + maven-version: ${{ matrix.MAVEN_VERSION }} + cache-key-prefix: ${{ matrix.OS }}-${{ matrix.JAVA_VERSION }}-maven${{ matrix.MAVEN_VERSION }} + - name: Checkout code + uses: actions/checkout@v4 + with: + fetch-depth: 0 + - run: | + cd images/tools/sonataflow-db-migrator + mvn test \ No newline at end of file diff --git a/images/tools/sonataflow-db-migrator/pom.xml b/images/tools/sonataflow-db-migrator/pom.xml index c0ac66421..e0a941b3d 100644 --- a/images/tools/sonataflow-db-migrator/pom.xml +++ b/images/tools/sonataflow-db-migrator/pom.xml @@ -172,10 +172,10 @@ - central - Maven Central + apache + Apache Maven default - https://repo1.maven.org/maven2 + https://repo.maven.apache.org/maven2/ false diff --git a/images/tools/sonataflow-db-migrator/src/test/java/org/kie/kogito/postgresql/migrator/DBMigratorTest.java b/images/tools/sonataflow-db-migrator/src/test/java/org/kie/kogito/postgresql/migrator/DBMigratorTest.java index 1bc0cd6a9..f88f960af 100644 --- a/images/tools/sonataflow-db-migrator/src/test/java/org/kie/kogito/postgresql/migrator/DBMigratorTest.java +++ b/images/tools/sonataflow-db-migrator/src/test/java/org/kie/kogito/postgresql/migrator/DBMigratorTest.java @@ -24,10 +24,6 @@ public class DBMigratorTest { DBMigrator dbMigrator = new DBMigrator(); - @BeforeAll - public static void init() { - } - @BeforeEach public void setupEach() { migrationService = mock(MigrationService.class); diff --git a/images/tools/sonataflow-db-migrator/src/test/java/org/kie/kogito/postgresql/migrator/MigrationServiceTest.java b/images/tools/sonataflow-db-migrator/src/test/java/org/kie/kogito/postgresql/migrator/MigrationServiceTest.java index 36043a79b..71a81681b 100644 --- a/images/tools/sonataflow-db-migrator/src/test/java/org/kie/kogito/postgresql/migrator/MigrationServiceTest.java +++ b/images/tools/sonataflow-db-migrator/src/test/java/org/kie/kogito/postgresql/migrator/MigrationServiceTest.java @@ -16,10 +16,6 @@ public class MigrationServiceTest { MigrationService migrationService = new MigrationService(); - @BeforeAll - public static void init() { - } - @BeforeEach public void setupEach() { flyway = mock(Flyway.class);