Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow user customization on generated knative resources #355

Closed
Tracked by #438
RichardW98 opened this issue Jan 16, 2024 · 1 comment
Closed
Tracked by #438

allow user customization on generated knative resources #355

RichardW98 opened this issue Jan 16, 2024 · 1 comment
Assignees
@RichardW98

Comments

@RichardW98
Copy link
Contributor

RichardW98 commented Jan 16, 2024 •
edited
Loading

Description

in #350, a central default broker is used for all sinkbindings and triggers. It is expected that user can have the flexibility to manage the config of generated knative resources from Sonataflow/SonataflowPlatform CR

Implementation ideas

as suggested here. user should be able to specify different brokers for events:
`spec:
events:
sink:
... # YOUR PROPOSAL
triggers:

  • event:
    broker: `

where all the options can still have a defined defaults from spec.sink
@RichardW98 RichardW98 changed the title allow user customization on trigger broker allow user customization on generated knative resources Jan 16, 2024
@ricardozanini ricardozanini added this to the Knative Eventing Integration M1 milestone Jan 16, 2024
@ricardozanini ricardozanini removed this from the Knative Eventing Integration M1 milestone Mar 25, 2024
@ricardozanini ricardozanini mentioned this issue Apr 9, 2024
Closed
7 tasks
@jianrongzhang89
Copy link
Contributor

This capability has been supported in #368, and this issue is no longer needed.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🎯 Done in 🦉 KIE Podling Board Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RichardW98 RichardW98

Labels
None yet
Projects
🦉 KIE Podling Board
Status: 🎯 Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ricardozanini @RichardW98 @jianrongzhang89