Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance error messages in SonataFlowPlatform CR status for knative integration #521

Closed
Tracked by #438
jianrongzhang89 opened this issue Aug 13, 2024 · 1 comment · Fixed by #558
Closed
Tracked by #438
Assignees

Comments

@jianrongzhang89
Copy link
Contributor

Description

With the implementation for the integration of SonataFlow Operator with Knative: #467, the platform reconciliation logic will log an error message when:

  1. the broker used for creating triggers is not created or available, or
  2. the SinkBinding has not injected K_SINK into the Job Services deployment
    and the reconciliation will resume after the condition has been resolved.

This follow up issue is to allow the operator to update the SonataFlowPlatform CR status with the corresponding error messages to inform the user that an error has happened.

Implementation ideas

To minimize the impact on the existing logic, it is suggested to use existing condition type "Running" with a Reason like "WaitingKnativeEventing" instead of introducing a new condition type.

@jianrongzhang89
Copy link
Contributor Author

This is a follow up issue after #467 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎯 Done
1 participant