-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SRVLOGIC-196] Rollout operator's deployment when custom configuration changes #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a minor observation, if you don't mind.
@dmartinol can u rebase? The problem was fixed in #332 |
done and also fixed the checksum annotation (twice, sorry). updated ADR accordingly |
No worries! That's why I suggested |
@dmartinol Please rebase, it should solve the issues with PR checks. |
@ricardozanini @wmedvede any further feedback? |
@domhanak will verify this PR, @dmartinol |
Thanks! Works well I did not run into issues. Here is apart of the deployment description after I updated its configMap with
|
…n changes (apache#325) * use annotations to restart deployment in prod profile, when cm changes * adding domain to checksum annotation * fixed missing / in checksum annotation * annotations can have only one '/': replaced the second with a dash '-' * Updated to use newDeploymentReconciler * Fixed test code while wiating for SRVLOGIC-195
…n changes (apache#325) * use annotations to restart deployment in prod profile, when cm changes * adding domain to checksum annotation * fixed missing / in checksum annotation * annotations can have only one '/': replaced the second with a dash '-' * Updated to use newDeploymentReconciler * Fixed test code while wiating for SRVLOGIC-195
Description of the change:
Use annotations to rollout the
Deployment
inprod
profile, when the propertiesConfigMap
changes. In particular, underspec.template.annotations
:checksum/config
: holds the sha256 encoded string of theapplication.properties
key of the propertiesConfigMap
sonataflow.org/restartedAt
: the timestamp when the last restart was requestedMotivation for the change:
To update the workflow application whenever the user configuration is updated on the cluster.
Checklist
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.