kie-kogito-serverless-operator-335: Operator driven service discovery API Phase4 #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmedvede
requested review from
ricardozanini and
jakubschwan
and removed request for
ricardozanini
|
@ricardozanini your suggestions were added. |
|
@ricardozanini left over removed! |
ricardozanini
approved these changes
Dec 27, 2023
jakubschwan
reviewed
Jan 10, 2024
wmedvede
force-pushed
the
kie-kogito-serverless-operator-335
branch
from
8f2b336
to
7dfd11f
Compare
… API Phase4
- Add the discovery of Openshift DeploymentConfigs and Routes to the service discovery API
… API Phase4
- Code review suggestions 1
… API Phase4
- Code review suggestions 2
… API Phase4
- Augment the service uri query parameters
wmedvede
force-pushed
the
kie-kogito-serverless-operator-335
branch
from
7dfd11f
to
0dd922d
Compare
domhanak
approved these changes
Jan 19, 2024
|
Closes #335 |
rgdoliveira
pushed a commit
to rgdoliveira/kogito-serverless-operator
that referenced
this pull request
Jan 29, 2024
… API Phase4 (apache#338) * kie-kogito-serverless-operator-335: Operator driven service discovery API Phase4 - Add the discovery of Openshift DeploymentConfigs and Routes to the service discovery API * kie-kogito-serverless-operator-335: Operator driven service discovery API Phase4 - Code review suggestions 1 * kie-kogito-serverless-operator-335: Operator driven service discovery API Phase4 - Code review suggestions 2 * kie-kogito-serverless-operator-335: Operator driven service discovery API Phase4 - Augment the service uri query parameters
rgdoliveira
pushed a commit
to rgdoliveira/kogito-serverless-operator
that referenced
this pull request
Jan 29, 2024
… API Phase4 (apache#338) * kie-kogito-serverless-operator-335: Operator driven service discovery API Phase4 - Add the discovery of Openshift DeploymentConfigs and Routes to the service discovery API * kie-kogito-serverless-operator-335: Operator driven service discovery API Phase4 - Code review suggestions 1 * kie-kogito-serverless-operator-335: Operator driven service discovery API Phase4 - Code review suggestions 2 * kie-kogito-serverless-operator-335: Operator driven service discovery API Phase4 - Augment the service uri query parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change:
Checklist
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.