Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kogito-serverless-operator-356: Temporary use of the nightly images #347

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

wmedvede
Copy link
Contributor

@wmedvede wmedvede commented Jan 11, 2024

Description of the change:

Motivation for the change:

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@wmedvede
Copy link
Contributor Author

Hi @jordigilh , would you mind review too?

Copy link
Contributor

@tchughesiv tchughesiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wmedvede the label selector fixes are already being addressed in #341 and appears ready to be merged. this PR should be limited to the nightly image change.

@wmedvede wmedvede force-pushed the kogito-serverless-operator-356 branch from c58dc12 to a016336 Compare January 11, 2024 15:53
@wmedvede wmedvede changed the title kogito-serverless-operator-356: Sonataflow platform managed services produce wrong selector kogito-serverless-operator-356: Temporary use of the nightly images Jan 11, 2024
@wmedvede
Copy link
Contributor Author

@wmedvede the label selector fixes are already being addressed in #341 and appears ready to be merged. this PR should be limited to the nightly image change.

@tchughesiv got it, I have merged #341, so now this PR is only for the temporary use of nightly images

Copy link

@jakubschwan jakubschwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wmedvede
Copy link
Contributor Author

wmedvede commented Jan 11, 2024

@ricardozanini merging at my own risk, since now that we manage many services, I'm starting to see difficult to do a working setup. I'll keep this on my radar and restore to the non nightly versions as soon as we can.

@wmedvede wmedvede merged commit 039efc3 into apache:main Jan 11, 2024
4 checks passed
@ricardozanini
Copy link
Member

@wmedvede can you do a follow-up PR to use https://github.com/apache/incubator-kie-kogito-serverless-operator/blob/main/version/version.go instead?

So we follow that approach, if we are on snapshot we use service nightly images.

rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Jan 29, 2024
rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants