-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kogito-serverless-operator-356: Temporary use of the nightly images #347
Conversation
Hi @jordigilh , would you mind review too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c58dc12
to
a016336
Compare
@tchughesiv got it, I have merged #341, so now this PR is only for the temporary use of nightly images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@ricardozanini merging at my own risk, since now that we manage many services, I'm starting to see difficult to do a working setup. I'll keep this on my radar and restore to the non nightly versions as soon as we can. |
@wmedvede can you do a follow-up PR to use https://github.com/apache/incubator-kie-kogito-serverless-operator/blob/main/version/version.go instead? So we follow that approach, if we are on snapshot we use service nightly images. |
Description of the change:
Motivation for the change:
Checklist
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.