-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KIE-830] Make SonataFlow Operator build reproducible #357
Conversation
docker pull quay.io/ederignatowicz/kogito-serverless-operator-nightly |
I was able to produce semantically equal images:
The diffs are:
|
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
9ddffb3
to
fd5a76e
Compare
Signed-off-by: Ricardo Zanini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @ricardozanini!
@porcelli the timestamp workaround is not working. The images are semantically equal per But, I think we should touch IPMC about this. How do we guarantee the images are reproducible? Is the |
Signed-off-by: Ricardo Zanini <[email protected]>
Guys, the images are identical now:
Merging! |
Signed-off-by: Ricardo Zanini <[email protected]>
* [KIE-830] Make SonataFlow Operator build reproducible Signed-off-by: Ricardo Zanini <[email protected]> * Add minor version to image.yaml Signed-off-by: Ricardo Zanini <[email protected]> * Force git date to the build files Signed-off-by: Ricardo Zanini <[email protected]> * Formatting issues Signed-off-by: Ricardo Zanini <[email protected]> * Use ubi9, add kind_version to e2e, fix ts on manager file Signed-off-by: Ricardo Zanini <[email protected]> * Fixing env var typo Signed-off-by: Ricardo Zanini <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]>
* [KIE-830] Make SonataFlow Operator build reproducible Signed-off-by: Ricardo Zanini <[email protected]> * Add minor version to image.yaml Signed-off-by: Ricardo Zanini <[email protected]> * Force git date to the build files Signed-off-by: Ricardo Zanini <[email protected]> * Formatting issues Signed-off-by: Ricardo Zanini <[email protected]> * Use ubi9, add kind_version to e2e, fix ts on manager file Signed-off-by: Ricardo Zanini <[email protected]> * Fixing env var typo Signed-off-by: Ricardo Zanini <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]>
Description of the change:
See apache/incubator-kie-issues#830.
TODO:
Motivation for the change:
Closes apache/incubator-kie-issues#830
Checklist
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.