Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-kogito-serverless-operator-379: Investigate why non-dev scenarios now requires JDBC configuration #386

Merged

Conversation

wmedvede
Copy link
Contributor

@wmedvede wmedvede commented Feb 7, 2024

- Use "latest" image tag and namespaced images generation.

Description of the change:
Closes #379

Motivation for the change:

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

… now requires JDBC configuration

    - Use "latest" image tag and namespaced images generation.
@wmedvede
Copy link
Contributor Author

wmedvede commented Feb 7, 2024

Guys @ricardozanini @domhanak , here goes the fix to use "latest" tagged images. Would you mind review?

e2e tests worked locally with minikube, let's see on the CI.

Thanks!

@domhanak domhanak requested review from jakubschwan and removed request for domhanak February 14, 2024 08:05
@domhanak
Copy link
Contributor

@jakubschwan is checking this

Copy link

@jakubschwan jakubschwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ricardozanini ricardozanini merged commit df462a8 into apache:main Feb 14, 2024
4 checks passed
wmedvede added a commit to wmedvede/kogito-serverless-operator that referenced this pull request Feb 19, 2024
… JDBC configuration

    - kie-kogito-serverless-operator-379: Investigate why non-dev scenarios now requires JDBC configuration (apache#386)

    - Use "latest" image tag and namespaced images generation.

(cherry picked from commit df462a8)
rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Mar 11, 2024
… now requires JDBC configuration (apache#386)

- Use "latest" image tag and namespaced images generation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate why non-dev scenarios now requires JDBC configuration
4 participants